Source/core/page/scrolling/ScrollingCoordinator.h - Issue 747903005: Pass integer scroll position to CC if frameView has non-layered viewport constrained objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/scrolling/ScrollingCoordinator.h

Issue 747903005: Pass integer scroll position to CC if frameView has non-layered viewport constrained objects (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: call updateDescendantDependentFlags() before calling hasVisibleContent() otherwise it crashes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | Source/core/page/scrolling/ScrollingCoordinator.cpp » ('j') | Source/core/page/scrolling/ScrollingCoordinator.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/scrolling/ScrollingCoordinator.h

diff --git a/Source/core/page/scrolling/ScrollingCoordinator.h b/Source/core/page/scrolling/ScrollingCoordinator.h

index 58c0e9e55a45df1e4bd38d1d22063756be59fdeb..863a2ee91b7f6dae3444ea9c2e719f6ded3a35bb 100644

--- a/Source/core/page/scrolling/ScrollingCoordinator.h

+++ b/Source/core/page/scrolling/ScrollingCoordinator.h

@@ -94,7 +94,7 @@ public:

void willDestroyScrollableArea(ScrollableArea*);

// Returns true if the coordinator handled this change.

- bool scrollableAreaScrollLayerDidChange(ScrollableArea*);

+ bool scrollableAreaScrollLayerDidChange(ScrollableArea*, bool = false);

void scrollableAreaScrollbarLayerDidChange(ScrollableArea*, ScrollbarOrientation);

void setLayerIsContainerForFixedPositionLayers(GraphicsLayer*, bool);

void updateLayerPositionConstraint(RenderLayer*);