Source/core/page/scrolling/ScrollingCoordinator.h - Issue 747903005: Pass integer scroll position to CC if frameView has non-layered viewport constrained objects

Side by Side Diff: Source/core/page/scrolling/ScrollingCoordinator.h

Issue 747903005: Pass integer scroll position to CC if frameView has non-layered viewport constrained objects (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: call updateDescendantDependentFlags() before calling hasVisibleContent() otherwise it crashes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Apple Inc. All rights reserved.	2 * Copyright (C) 2011 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 76 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
87 ThreadedScrollingDisabled = 1 << 3	87 ThreadedScrollingDisabled = 1 << 3

88 };	88 };

89	89

90 MainThreadScrollingReasons mainThreadScrollingReasons() const;	90 MainThreadScrollingReasons mainThreadScrollingReasons() const;

91 bool shouldUpdateScrollLayerPositionOnMainThread() const { return mainThread ScrollingReasons() != 0; }	91 bool shouldUpdateScrollLayerPositionOnMainThread() const { return mainThread ScrollingReasons() != 0; }

92	92

93 PassOwnPtr<blink::WebScrollbarLayer> createSolidColorScrollbarLayer(Scrollba rOrientation, int thumbThickness, int trackStart, bool isLeftSideVerticalScrollb ar);	93 PassOwnPtr<blink::WebScrollbarLayer> createSolidColorScrollbarLayer(Scrollba rOrientation, int thumbThickness, int trackStart, bool isLeftSideVerticalScrollb ar);

94	94

95 void willDestroyScrollableArea(ScrollableArea*);	95 void willDestroyScrollableArea(ScrollableArea*);

96 // Returns true if the coordinator handled this change.	96 // Returns true if the coordinator handled this change.

97 bool scrollableAreaScrollLayerDidChange(ScrollableArea*);	97 bool scrollableAreaScrollLayerDidChange(ScrollableArea*, bool = false);

98 void scrollableAreaScrollbarLayerDidChange(ScrollableArea*, ScrollbarOrienta tion);	98 void scrollableAreaScrollbarLayerDidChange(ScrollableArea*, ScrollbarOrienta tion);

99 void setLayerIsContainerForFixedPositionLayers(GraphicsLayer*, bool);	99 void setLayerIsContainerForFixedPositionLayers(GraphicsLayer*, bool);

100 void updateLayerPositionConstraint(RenderLayer*);	100 void updateLayerPositionConstraint(RenderLayer*);

101 void touchEventTargetRectsDidChange();	101 void touchEventTargetRectsDidChange();

102 void willDestroyRenderLayer(RenderLayer*);	102 void willDestroyRenderLayer(RenderLayer*);

103	103

104 void updateScrollParentForGraphicsLayer(GraphicsLayer* child, RenderLayer* p arent);	104 void updateScrollParentForGraphicsLayer(GraphicsLayer* child, RenderLayer* p arent);

105 void updateClipParentForGraphicsLayer(GraphicsLayer* child, RenderLayer* par ent);	105 void updateClipParentForGraphicsLayer(GraphicsLayer* child, RenderLayer* par ent);

106	106

107 static String mainThreadScrollingReasonsAsText(MainThreadScrollingReasons);	107 static String mainThreadScrollingReasonsAsText(MainThreadScrollingReasons);

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
150 HashSet<const RenderLayer*> m_layersWithTouchRects;	150 HashSet<const RenderLayer*> m_layersWithTouchRects;

151 bool m_wasFrameScrollable;	151 bool m_wasFrameScrollable;

152	152

153 // This is retained for testing.	153 // This is retained for testing.

154 MainThreadScrollingReasons m_lastMainThreadScrollingReasons;	154 MainThreadScrollingReasons m_lastMainThreadScrollingReasons;

155 };	155 };

156	156

157 } // namespace blink	157 } // namespace blink

158	158

159 #endif // ScrollingCoordinator_h	159 #endif // ScrollingCoordinator_h

OLD	NEW