Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: Source/core/frame/FrameView.cpp

Issue 747903005: Pass integer scroll position to CC if frameView has non-layered viewport constrained objects (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: call updateDescendantDependentFlags() before calling hasVisibleContent() otherwise it crashes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index 80bbf1b9c1caa164c41519188afb2ff8c9b8d76d..c22e19f8bfb14fb892ebb6f639e6a977459a7f07 100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -1268,6 +1268,22 @@ LayoutRect FrameView::viewportConstrainedVisibleContentRect() const
return viewportRect;
}
+bool FrameView::hasVisibleViewportConstrainedObjects() const
+{
+ const ViewportConstrainedObjectSet* objects = viewportConstrainedObjects();
+ if (!objects)
+ return false;
+ for (const RenderObject* renderer : *objects) {
+ RenderLayer* layer = toRenderBoxModelObject(renderer)->layer();
+ if (layer) {
+ layer->updateDescendantDependentFlags();
+ if (!layer->subtreeIsInvisible())
+ return true;
+ }
+ }
+ return false;
+}
+
void FrameView::viewportConstrainedVisibleContentSizeChanged(bool widthChanged, bool heightChanged)
{
if (!hasViewportConstrainedObjects())

Powered by Google App Engine
This is Rietveld 408576698