Source/core/frame/FrameView.h - Issue 747903005: Pass integer scroll position to CC if frameView has non-layered viewport constrained objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameView.h

Issue 747903005: Pass integer scroll position to CC if frameView has non-layered viewport constrained objects (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: call updateDescendantDependentFlags() before calling hasVisibleContent() otherwise it crashes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/FrameView.h

diff --git a/Source/core/frame/FrameView.h b/Source/core/frame/FrameView.h

index 5cf83bcf64a013ccf241c8fe0595b437e1dff3fe..ab773f9b9c40c63055a59e8a423a90cc56c7fad0 100644

--- a/Source/core/frame/FrameView.h

+++ b/Source/core/frame/FrameView.h

@@ -185,6 +185,7 @@ public:

void removeViewportConstrainedObject(RenderObject*);

const ViewportConstrainedObjectSet* viewportConstrainedObjects() const { return m_viewportConstrainedObjects.get(); }

bool hasViewportConstrainedObjects() const { return m_viewportConstrainedObjects && m_viewportConstrainedObjects->size() > 0; }

+ bool hasVisibleViewportConstrainedObjects() const;

void handleLoadCompleted();

« no previous file with comments | « no previous file | Source/core/frame/FrameView.cpp » ('j') | Source/core/page/scrolling/ScrollingCoordinator.cpp » ('J')