Source/core/frame/FrameView.h - Issue 747903005: Pass integer scroll position to CC if frameView has non-layered viewport constrained objects

Side by Side Diff: Source/core/frame/FrameView.h

Issue 747903005: Pass integer scroll position to CC if frameView has non-layered viewport constrained objects (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: call updateDescendantDependentFlags() before calling hasVisibleContent() otherwise it crashes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 Copyright (C) 1997 Martin Jones (mjones@kde.org)	2 Copyright (C) 1997 Martin Jones (mjones@kde.org)

3 (C) 1998 Waldo Bastian (bastian@kde.org)	3 (C) 1998 Waldo Bastian (bastian@kde.org)

4 (C) 1998, 1999 Torben Weis (weis@kde.org)	4 (C) 1998, 1999 Torben Weis (weis@kde.org)

5 (C) 1999 Lars Knoll (knoll@kde.org)	5 (C) 1999 Lars Knoll (knoll@kde.org)

6 (C) 1999 Antti Koivisto (koivisto@kde.org)	6 (C) 1999 Antti Koivisto (koivisto@kde.org)

7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.	7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.

8	8

9 This library is free software; you can redistribute it and/or	9 This library is free software; you can redistribute it and/or

10 modify it under the terms of the GNU Library General Public	10 modify it under the terms of the GNU Library General Public

(...skipping 167 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
178 void addSlowRepaintObject();	178 void addSlowRepaintObject();

179 void removeSlowRepaintObject();	179 void removeSlowRepaintObject();

180 bool hasSlowRepaintObjects() const { return m_slowRepaintObjectCount; }	180 bool hasSlowRepaintObjects() const { return m_slowRepaintObjectCount; }

181	181

182 // Fixed-position objects.	182 // Fixed-position objects.

183 typedef HashSet<RenderObject*> ViewportConstrainedObjectSet;	183 typedef HashSet<RenderObject*> ViewportConstrainedObjectSet;

184 void addViewportConstrainedObject(RenderObject*);	184 void addViewportConstrainedObject(RenderObject*);

185 void removeViewportConstrainedObject(RenderObject*);	185 void removeViewportConstrainedObject(RenderObject*);

186 const ViewportConstrainedObjectSet* viewportConstrainedObjects() const { ret urn m_viewportConstrainedObjects.get(); }	186 const ViewportConstrainedObjectSet* viewportConstrainedObjects() const { ret urn m_viewportConstrainedObjects.get(); }

187 bool hasViewportConstrainedObjects() const { return m_viewportConstrainedObj ects && m_viewportConstrainedObjects->size() > 0; }	187 bool hasViewportConstrainedObjects() const { return m_viewportConstrainedObj ects && m_viewportConstrainedObjects->size() > 0; }

	188 bool hasVisibleViewportConstrainedObjects() const;

188	189

189 void handleLoadCompleted();	190 void handleLoadCompleted();

190	191

191 void updateAnnotatedRegions();	192 void updateAnnotatedRegions();

192	193

193 void restoreScrollbar();	194 void restoreScrollbar();

194	195

195 void postLayoutTimerFired(Timer<FrameView>*);	196 void postLayoutTimerFired(Timer<FrameView>*);

196	197

197 bool wasScrolledByUser() const;	198 bool wasScrolledByUser() const;

(...skipping 646 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
844 }	845 }

845	846

846 private:	847 private:

847 RawPtrWillBeMember<FrameView> m_view;	848 RawPtrWillBeMember<FrameView> m_view;

848 bool m_originalValue;	849 bool m_originalValue;

849 };	850 };

850	851

851 } // namespace blink	852 } // namespace blink

852	853

853 #endif // FrameView_h	854 #endif // FrameView_h

OLD	NEW

« no previous file with comments | « no previous file | Source/core/frame/FrameView.cpp » ('j') | Source/core/page/scrolling/ScrollingCoordinator.cpp » ('J')