Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: chrome/renderer/extensions/object_backed_native_handler.cc

Issue 74783006: Remove deprecated v8::External::New calls (chromium side) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/module_system.cc ('k') | gin/modules/module_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/object_backed_native_handler.cc
diff --git a/chrome/renderer/extensions/object_backed_native_handler.cc b/chrome/renderer/extensions/object_backed_native_handler.cc
index a58f752d666286b461f6ab7e2afd6ccbc8fbebdd..858016f041316e3133902a446e016385ba6cebee 100644
--- a/chrome/renderer/extensions/object_backed_native_handler.cc
+++ b/chrome/renderer/extensions/object_backed_native_handler.cc
@@ -64,8 +64,9 @@ void ObjectBackedNativeHandler::RouteFunction(
v8::Persistent<v8::Object> data(isolate, v8::Object::New());
v8::Local<v8::Object> local_data = v8::Local<v8::Object>::New(isolate, data);
- local_data->Set(v8::String::New(kHandlerFunction),
- v8::External::New(new HandlerFunction(handler_function)));
+ local_data->Set(
+ v8::String::New(kHandlerFunction),
+ v8::External::New(isolate, new HandlerFunction(handler_function)));
v8::Handle<v8::FunctionTemplate> function_template =
v8::FunctionTemplate::New(Router, local_data);
object_template_.NewHandle(isolate)->Set(name.c_str(), function_template);
« no previous file with comments | « chrome/renderer/extensions/module_system.cc ('k') | gin/modules/module_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698