gin/modules/module_registry.cc - Issue 74783006: Remove deprecated v8::External::New calls (chromium side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/modules/module_registry.cc

Issue 74783006: Remove deprecated v8::External::New calls (chromium side) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/modules/module_registry.cc

diff --git a/gin/modules/module_registry.cc b/gin/modules/module_registry.cc

index 78a102c0a6da5186e83987ecef41716181d4c8f0..bfa05a159734f39fa46a39b0ed990779bae53195 100644

--- a/gin/modules/module_registry.cc

+++ b/gin/modules/module_registry.cc

@@ -119,7 +119,8 @@ ModuleRegistry* ModuleRegistry::From(Handle<v8::Context> context) {

if (!data)

return NULL;

ModuleRegistry* registry = new ModuleRegistry(isolate);

- context->Global()->SetHiddenValue(key, v8::External::New(registry));

+ context->Global()->SetHiddenValue(key,

+ v8::External::New(isolate, registry));

data->AddSupplement(registry);

return registry;

}