chrome/renderer/extensions/module_system.cc - Issue 74783006: Remove deprecated v8::External::New calls (chromium side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/module_system.cc

Issue 74783006: Remove deprecated v8::External::New calls (chromium side) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/module_system.cc

diff --git a/chrome/renderer/extensions/module_system.cc b/chrome/renderer/extensions/module_system.cc

index 65a5cad1aeee60920a86f87107dc40a7d5e1f270..d9cf8bba75b5121b39c809cd0bf979afae5ea914 100644

--- a/chrome/renderer/extensions/module_system.cc

+++ b/chrome/renderer/extensions/module_system.cc

@@ -132,7 +132,7 @@ ModuleSystem::ModuleSystem(ChromeV8Context* context, SourceMap* source_map)

v8::Handle<v8::Object> global(context->v8_context()->Global());

global->SetHiddenValue(v8::String::New(kModulesField), v8::Object::New());

global->SetHiddenValue(v8::String::New(kModuleSystem),

- v8::External::New(this));

+ v8::External::New(context->isolate(), this));

}

ModuleSystem::~ModuleSystem() {