Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 74783006: Remove deprecated v8::External::New calls (chromium side) (Closed)

Created:
7 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M chrome/renderer/extensions/console.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/renderer/extensions/module_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/object_backed_native_handler.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M gin/modules/module_registry.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/proxy/proxy_resolver_v8.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-18 10:30:14 UTC) #1
dcarney
lgtm
7 years, 1 month ago (2013-11-18 10:33:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/74783006/1
7 years, 1 month ago (2013-11-18 10:41:28 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 16:47:56 UTC) #4
Message was sent while issue was closed.
Change committed as 235745

Powered by Google App Engine
This is Rietveld 408576698