Issue 74693003: Editing: Minor cleanup/Removal of redundant function call

Issue 74693003: Editing: Minor cleanup/Removal of redundant function call (Closed)

Created:
7 years, 1 month ago by vanihegde

Modified:
7 years, 1 month ago

Reviewers:
leviw_travelin_and_unemployed, ojan, yosin_UTC9, eseidel

CC:
blink-reviews, groby+blinkspell_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Editing: Minor cleanup/Removal of redundant function call Minor code cleanup and removal of redundant upstream() call. All layout tests executed. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162222

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -4 lines)			Patch
M	Source/core/editing/ApplyStyleCommand.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/editing/Editor.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/editing/InsertTextCommand.cpp	View	1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

yosin_UTC9

https://codereview.chromium.org/74693003/diff/1/Source/core/editing/InsertTextCommand.cpp File Source/core/editing/InsertTextCommand.cpp (right): https://codereview.chromium.org/74693003/diff/1/Source/core/editing/InsertTextCommand.cpp#newcode177 Source/core/editing/InsertTextCommand.cpp:177: deleteInsignificantText(startPosition, startPosition.downstream()); I'm not sure why we can remove ...

7 years, 1 month ago (2013-11-18 05:42:39 UTC) #2

vanihegde

7 years, 1 month ago (2013-11-18 05:47:33 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vani.hegde@samsung.com/74693003/1

7 years, 1 month ago (2013-11-18 17:56:46 UTC) #6

Message was sent while issue was closed.

Change committed as 162222

Expand Messages | Collapse Messages