Editing: Minor cleanup/Removal of redundant function call

Source/core/editing/InsertTextCommand.cpp

 /*
  * Copyright (C) 2005 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 156 matching lines @@
         // we get a chance to insert into it.  We check for a placeholder now, though, because doing so requires
         // the creation of a VisiblePosition, and if we did that post-insertion it would force a layout.
     }
 
     // Insert the character at the leftmost candidate.
     startPosition = startPosition.upstream();
 
     // It is possible for the node that contains startPosition to contain only unrendered whitespace,
     // and so deleteInsignificantText could remove it.  Save the position before the node in case that happens.
     Position positionBeforeStartNode(positionInParentBeforeNode(startPosition.containerNode()));
-    deleteInsignificantText(startPosition.upstream(), startPosition.downstream());
+    deleteInsignificantText(startPosition, startPosition.downstream());

[yosin_UTC9, 2013/11/18 05:42:39]

I'm not sure why we can remove upstream()...

[vanihegde, 2013/11/18 05:47:33]

It's already done above (line 172)
startPosition = startPosition.upstream();

And startPosition is unchanged after that. So we can use it as is.

     if (!startPosition.inDocument())
         startPosition = positionBeforeStartNode;
     if (!startPosition.isCandidate())
         startPosition = startPosition.downstream();
 
     startPosition = positionAvoidingSpecialElementBoundary(startPosition);
 
     Position endPosition;
 
     if (m_text == "\t") {
@@ skipping 76 matching lines @@
                 splitTextNode(textNode, offset);
             insertNodeBefore(spanNode, textNode.release());
         }
     }
 
     // return the position following the new tab
     return lastPositionInNode(spanNode.get());
 }
 
 }