Source/core/editing/InsertTextCommand.cpp - Issue 74693003: Editing: Minor cleanup/Removal of redundant function call

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/InsertTextCommand.cpp

Issue 74693003: Editing: Minor cleanup/Removal of redundant function call (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/InsertTextCommand.cpp

diff --git a/Source/core/editing/InsertTextCommand.cpp b/Source/core/editing/InsertTextCommand.cpp

index 00ba6a7a4e4edb69ab7f1fd4f7d8d2e9ddfb2707..8a489403ed095da3d9dbf6fd7bfdae5ad725688b 100644

--- a/Source/core/editing/InsertTextCommand.cpp

+++ b/Source/core/editing/InsertTextCommand.cpp

@@ -174,7 +174,7 @@ void InsertTextCommand::doApply()

// It is possible for the node that contains startPosition to contain only unrendered whitespace,

// and so deleteInsignificantText could remove it. Save the position before the node in case that happens.

Position positionBeforeStartNode(positionInParentBeforeNode(startPosition.containerNode()));

- deleteInsignificantText(startPosition.upstream(), startPosition.downstream());

+ deleteInsignificantText(startPosition, startPosition.downstream());

yosin_UTC9 2013/11/18 05:42:39 I'm not sure why we can remove upstream()...

vanihegde 2013/11/18 05:47:33 It's already done above (line 172) startPosition =

if (!startPosition.inDocument())

startPosition = positionBeforeStartNode;

if (!startPosition.isCandidate())

« no previous file with comments | « Source/core/editing/Editor.cpp ('k') | no next file » | no next file with comments »