Issue 7466004: Message validation in message dispatchers.

Issue 7466004: Message validation in message dispatchers. (Closed)

Created:
9 years, 5 months ago by Sergey Ulanov

Modified:
9 years, 5 months ago

Reviewers:
Wez, Alpha Left Google

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Message validation in message dispatchers. BUG=70335 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93296

Patch Set 1 #

Total comments: 2

Patch Set 2 : - #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -92 lines)			Patch
M	remoting/client/chromoting_client.h	View		1 chunk	+7 lines, -8 lines	0 comments	Download
M	remoting/client/chromoting_client.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	remoting/host/client_session.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	remoting/host/client_session.cc	View	1	1 chunk	+0 lines, -11 lines	0 comments	Download
M	remoting/proto/control.proto	View	1	2 chunks	+2 lines, -11 lines	0 comments	Download
M	remoting/proto/internal.proto	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	remoting/protocol/client_control_sender.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	remoting/protocol/client_control_sender.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	remoting/protocol/client_message_dispatcher.cc	View		1 chunk	+10 lines, -11 lines	0 comments	Download
M	remoting/protocol/client_stub.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	remoting/protocol/host_control_sender.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	remoting/protocol/host_control_sender.cc	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	remoting/protocol/host_message_dispatcher.cc	View	1	2 chunks	+14 lines, -13 lines	0 comments	Download
M	remoting/protocol/host_stub.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	remoting/protocol/protocol_mock_objects.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Wez

LGTM, but see comment re SuggestResolution. http://codereview.chromium.org/7466004/diff/1/remoting/protocol/host_message_dispatcher.cc File remoting/protocol/host_message_dispatcher.cc (right): http://codereview.chromium.org/7466004/diff/1/remoting/protocol/host_message_dispatcher.cc#newcode65 remoting/protocol/host_message_dispatcher.cc:65: host_stub_->SuggestResolution(&resolution, done_task); We ...

9 years, 5 months ago (2011-07-20 21:45:14 UTC) #2

Sergey Ulanov

9 years, 5 months ago (2011-07-20 22:04:19 UTC) #3

http://codereview.chromium.org/7466004/diff/1/remoting/protocol/host_message_...
File remoting/protocol/host_message_dispatcher.cc (right):

http://codereview.chromium.org/7466004/diff/1/remoting/protocol/host_message_...
remoting/protocol/host_message_dispatcher.cc:65:
host_stub_->SuggestResolution(&resolution, done_task);
On 2011/07/20 21:45:14, Wez wrote:
> We don't ever send or handle SuggestResolution messages, so perhaps we should
> strip it out for now; we can re-introduce a mechanism once we have something
> designed.

Done.

Expand Messages | Collapse Messages