Message validation in message dispatchers.

remoting/protocol/client_message_dispatcher.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/ref_counted.h"
 #include "net/base/io_buffer.h"
 #include "remoting/proto/control.pb.h"
 #include "remoting/proto/event.pb.h"
 #include "remoting/proto/internal.pb.h"
 #include "remoting/protocol/client_message_dispatcher.h"
@@ skipping 21 matching lines @@
   client_stub_ = client_stub;
 
   control_message_reader_->Init(
       session->control_channel(),
       NewCallback(this, &ClientMessageDispatcher::OnControlMessageReceived));
   return;
 }
 
 void ClientMessageDispatcher::OnControlMessageReceived(
     ControlMessage* message, Task* done_task) {
-  // TODO(sergeyu): Add message validation.
-  if (message->has_notify_resolution()) {
-    client_stub_->NotifyResolution(
-        &message->notify_resolution(), done_task);
-    return;
-  } else if (message->has_begin_session_response()) {
-    client_stub_->BeginSessionResponse(
-        &message->begin_session_response().login_status(), done_task);
-    return;
-  } else {
-    LOG(WARNING) << "Invalid control message received.";
+  if (message->has_begin_session_response()) {
+    const BeginSessionResponse& response = message->begin_session_response();
+    if (response.has_login_status() &&
+        response.login_status().has_success()) {
+      client_stub_->BeginSessionResponse(
+          &response.login_status(), done_task);
+      return;
+    }
   }
 
+  LOG(WARNING) << "Invalid control message received.";
+
   done_task->Run();
   delete done_task;
 }
 
 }  // namespace protocol
 }  // namespace remoting