Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: remoting/protocol/host_message_dispatcher.cc

Issue 7466004: Message validation in message dispatchers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: - Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/host_control_sender.cc ('k') | remoting/protocol/host_stub.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/host_message_dispatcher.cc
diff --git a/remoting/protocol/host_message_dispatcher.cc b/remoting/protocol/host_message_dispatcher.cc
index 807234e2193edc075b57b3295ff16bba60c30e33..c2b6423836b3306247ef90a599359d707a2e8765 100644
--- a/remoting/protocol/host_message_dispatcher.cc
+++ b/remoting/protocol/host_message_dispatcher.cc
@@ -52,16 +52,14 @@ void HostMessageDispatcher::Initialize(
void HostMessageDispatcher::OnControlMessageReceived(
ControlMessage* message, Task* done_task) {
- // TODO(sergeyu): Add message validation.
if (message->has_begin_session_request()) {
- host_stub_->BeginSessionRequest(
- &message->begin_session_request().credentials(), done_task);
- return;
- }
- if (message->has_suggest_resolution()) {
- host_stub_->SuggestResolution(&message->suggest_resolution(), done_task);
- return;
+ const BeginSessionRequest& request = message->begin_session_request();
+ if (request.has_credentials() && request.credentials().has_type()) {
+ host_stub_->BeginSessionRequest(&request.credentials(), done_task);
+ return;
+ }
}
+
LOG(WARNING) << "Invalid control message received.";
done_task->Run();
delete done_task;
@@ -69,16 +67,19 @@ void HostMessageDispatcher::OnControlMessageReceived(
void HostMessageDispatcher::OnEventMessageReceived(
EventMessage* message, Task* done_task) {
- // TODO(sergeyu): Add message validation.
connection_->UpdateSequenceNumber(message->sequence_number());
+
if (message->has_key_event()) {
- input_stub_->InjectKeyEvent(&message->key_event(), done_task);
- return;
- }
- if (message->has_mouse_event()) {
+ const KeyEvent& event = message->key_event();
+ if (event.has_keycode() && event.has_pressed()) {
+ input_stub_->InjectKeyEvent(&event, done_task);
+ return;
+ }
+ } else if (message->has_mouse_event()) {
input_stub_->InjectMouseEvent(&message->mouse_event(), done_task);
return;
}
+
LOG(WARNING) << "Invalid event message received.";
done_task->Run();
delete done_task;
« no previous file with comments | « remoting/protocol/host_control_sender.cc ('k') | remoting/protocol/host_stub.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698