Mark the Notification as being closed before dispatching the event.

Mark the Notification as being closed before dispatching the event.

This avoids a situation in which we can crash when the developer calls
the Notification.close() method in the "onclose" event of a Notification.

BUG=435201
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185800

[Peter Beverloo, 2014-11-21 12:11:15]

peter@chromium.org changed reviewers:
+ mkwst@chromium.org

[Peter Beverloo, 2014-11-21 12:11:16]

Mike: PTAL.

This unfortunately isn't testable from Blink without plumbing through a
TestRunner call for simulating closing a notification, and I don't think that's
worth it. Verified manually.

[Peter Beverloo, 2014-11-21 13:39:03]

On 2014/11/21 12:11:16, Peter Beverloo wrote:
> Mike: PTAL.
> 
> This unfortunately isn't testable from Blink without plumbing through a
> TestRunner call for simulating closing a notification, and I don't think
that's
> worth it. Verified manually.

Browser test uploaded here, for reasons outlined in the bug:
  https://codereview.chromium.org/752533002

[Mike West, 2014-11-21 13:51:21]

LGTM, thanks for the browser test.

[Peter Beverloo, 2014-11-21 13:51:40]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2014-11-21 13:52:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/745713003/1

[commit-bot: I haz the power, 2014-11-21 15:06:16]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185800