Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 752533002: Add a browser test to verify that double-closing a notification does not crash. (Closed)

Created:
6 years, 1 month ago by Peter Beverloo
Modified:
6 years ago
Reviewers:
Jun Mukai, Mike West
CC:
chromium-reviews, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a browser test to verify that double-closing a notification does not crash. BUG=435201 Committed: https://crrev.com/c50e90e50d4d105f0d2260385a2090d9108c9fa3 Cr-Commit-Position: refs/heads/master@{#305495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -2 lines) Patch
M chrome/browser/notifications/notification_browsertest.cc View 2 chunks +34 lines, -2 lines 0 comments Download
A chrome/test/data/notifications/notification-double-close.html View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Peter Beverloo
Jun: PTAL. This depends on the following Blink patch: https://codereview.chromium.org/745713003/
6 years, 1 month ago (2014-11-21 13:39:46 UTC) #2
Mike West
LGTM, thanks for uploading this followup to the Blink-side patch.
6 years, 1 month ago (2014-11-21 13:52:11 UTC) #4
Jun Mukai
lgtm
6 years, 1 month ago (2014-11-21 21:14:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/752533002/1
6 years ago (2014-11-24 12:22:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/1792)
6 years ago (2014-11-24 13:20:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/752533002/1
6 years ago (2014-11-24 20:53:43 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-24 21:26:40 UTC) #12
commit-bot: I haz the power
6 years ago (2014-11-24 21:27:57 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c50e90e50d4d105f0d2260385a2090d9108c9fa3
Cr-Commit-Position: refs/heads/master@{#305495}

Powered by Google App Engine
This is Rietveld 408576698