Source/modules/notifications/Notification.cpp - Issue 745713003: Mark the Notification as being closed before dispatching the event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/Notification.cpp

Issue 745713003: Mark the Notification as being closed before dispatching the event. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/notifications/Notification.cpp

diff --git a/Source/modules/notifications/Notification.cpp b/Source/modules/notifications/Notification.cpp

index 212abc10a87ffc203f632f35fb5cbd9a2b003cb7..6c0587fff8cb74e626169073a0388e791b290785 100644

--- a/Source/modules/notifications/Notification.cpp

+++ b/Source/modules/notifications/Notification.cpp

@@ -139,8 +139,8 @@ void Notification::dispatchErrorEvent()

void Notification::dispatchCloseEvent()

{

- dispatchEvent(Event::create(EventTypeNames::close));

m_state = NotificationStateClosed;

+ dispatchEvent(Event::create(EventTypeNames::close));

}

TextDirection Notification::direction() const

« no previous file with comments | « no previous file | no next file » | no next file with comments »