Remove implicit conversions from scoped_refptr to T* in chrome/

Remove implicit conversions from scoped_refptr to T* in chrome/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Windows build.

BUG=110610
Committed: https://crrev.com/81762e001c5c58b778a883fdace89975db9ee084
Cr-Commit-Position: refs/heads/master@{#305286}

[dcheng, 2014-11-21 17:25:17]

dcheng@chromium.org changed reviewers:
+ thestig@chromium.org

[dcheng, 2014-11-21 17:25:18]

https://codereview.chromium.org/745333002/diff/1/chrome/browser/ui/pdf/adobe_...
File chrome/browser/ui/pdf/adobe_reader_info_win.cc (right):

https://codereview.chromium.org/745333002/diff/1/chrome/browser/ui/pdf/adobe_...
chrome/browser/ui/pdf/adobe_reader_info_win.cc:91: scoped_refptr<PluginPrefs>
plugin_prefs =
Note: the plugin rewrote the variable type here. In general, it considers it
unsafe to turn a temporary scoped_refptr<> directly into a raw pointer, since
that temporary might be the only reference to it. Let me know if you'd like me
to revert this to a raw pointer.

[Lei Zhang, 2014-11-21 17:44:28]

lgtm

https://codereview.chromium.org/745333002/diff/1/chrome/browser/shell_integra...
File chrome/browser/shell_integration_win.cc (right):

https://codereview.chromium.org/745333002/diff/1/chrome/browser/shell_integra...
chrome/browser/shell_integration_win.cc:493:
property_store->GetValue(PKEY_AppUserModel_ID, propvariant.Receive()) !=
nit: the prev code looks more readable to me.

https://codereview.chromium.org/745333002/diff/1/chrome/browser/ui/pdf/adobe_...
File chrome/browser/ui/pdf/adobe_reader_info_win.cc (right):

https://codereview.chromium.org/745333002/diff/1/chrome/browser/ui/pdf/adobe_...
chrome/browser/ui/pdf/adobe_reader_info_win.cc:91: scoped_refptr<PluginPrefs>
plugin_prefs =
On 2014/11/21 17:25:18, dcheng wrote:
> Note: the plugin rewrote the variable type here. In general, it considers it
> unsafe to turn a temporary scoped_refptr<> directly into a raw pointer, since
> that temporary might be the only reference to it. Let me know if you'd like me
> to revert this to a raw pointer.

This is fine, thanks for catching it.

[dcheng, 2014-11-21 19:12:11]

https://codereview.chromium.org/745333002/diff/1/chrome/browser/shell_integra...
File chrome/browser/shell_integration_win.cc (right):

https://codereview.chromium.org/745333002/diff/1/chrome/browser/shell_integra...
chrome/browser/shell_integration_win.cc:493:
property_store->GetValue(PKEY_AppUserModel_ID, propvariant.Receive()) !=
On 2014/11/21 17:44:28, Lei Zhang wrote:
> nit: the prev code looks more readable to me.

This was the result of clang-format. I'm happy to file a bug for this; how
strongly do you feel about reverting this particular change? Obviously, my
preference would be to defer to clang-format if you don't think it's a big deal,
since it makes things a bit easier for me.

[Lei Zhang, 2014-11-21 19:14:45]

On 2014/11/21 19:12:11, dcheng wrote:
>
https://codereview.chromium.org/745333002/diff/1/chrome/browser/shell_integra...
> File chrome/browser/shell_integration_win.cc (right):
> 
>
https://codereview.chromium.org/745333002/diff/1/chrome/browser/shell_integra...
> chrome/browser/shell_integration_win.cc:493:
> property_store->GetValue(PKEY_AppUserModel_ID, propvariant.Receive()) !=
> On 2014/11/21 17:44:28, Lei Zhang wrote:
> > nit: the prev code looks more readable to me.
> 
> This was the result of clang-format. I'm happy to file a bug for this; how
> strongly do you feel about reverting this particular change? Obviously, my
> preference would be to defer to clang-format if you don't think it's a big
deal,
> since it makes things a bit easier for me.

Not a big deal, but if you can file a bug for this with clang-format, that would
be great.

[dcheng, 2014-11-21 20:30:39]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-11-21 20:31:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/745333002/1

[commit-bot: I haz the power, 2014-11-21 21:22:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-21 21:23:18]

Patchset 1 (id:??) landed as
https://crrev.com/81762e001c5c58b778a883fdace89975db9ee084
Cr-Commit-Position: refs/heads/master@{#305286}