Remove implicit conversions from scoped_refptr to T* in chrome/

chrome/browser/ui/pdf/adobe_reader_info_win.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/pdf/adobe_reader_info_win.h"
 
 #include <shlwapi.h>
 
 #include <algorithm>
 #include <vector>
@@ skipping 70 matching lines @@
                      IsPdfMimeType) == plugin.mime_types.end())
       continue;
     scoped_ptr<PluginMetadata> plugin_metadata(
         plugin_finder->GetPluginMetadata(plugins[i]));
     if (plugin_metadata->identifier() != kAdobeReaderIdentifier)
       continue;
 
     reader_info.is_installed = true;
 
     if (profile) {
-      PluginPrefs* plugin_prefs = PluginPrefs::GetForProfile(profile);
+      scoped_refptr<PluginPrefs> plugin_prefs =

[dcheng, 2014/11/21 17:25:18]

Note: the plugin rewrote the variable type here. In general, it considers it
unsafe to turn a temporary scoped_refptr<> directly into a raw pointer, since
that temporary might be the only reference to it. Let me know if you'd like me
to revert this to a raw pointer.

[Lei Zhang, 2014/11/21 17:44:28]

This is fine, thanks for catching it.

+          PluginPrefs::GetForProfile(profile);
       PluginPrefs::PolicyStatus plugin_status =
           plugin_prefs->PolicyStatusForPlugin(plugin_metadata->name());
       reader_info.is_enabled = plugin_status != PluginPrefs::POLICY_DISABLED;
     }
 
     // Adobe Reader will likely always come up as "requires_authorization".
     // See http://crbug.com/311655.
     PluginMetadata::SecurityStatus security_stat =
         plugin_metadata->GetSecurityStatus(plugins[i]);
     reader_info.is_secure =
@@ skipping 75 matching lines @@
       base::UTF16ToUTF8(file_version_info->product_version());
   // Convert 1.2.03.45 to 1.2.3.45 so base::Version considers it as valid.
   for (int i = 1; i <= 9; ++i) {
     std::string from = base::StringPrintf(".0%d", i);
     std::string to = base::StringPrintf(".%d", i);
     ReplaceSubstringsAfterOffset(&reader_version, 0, from, to);
   }
   base::Version file_version(reader_version);
   return file_version.IsValid() && !file_version.IsOlderThan(kSecureVersion);
 }