chrome/browser/metro_utils/metro_chrome_win.cc - Issue 745333002: Remove implicit conversions from scoped_refptr to T* in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metro_utils/metro_chrome_win.cc

Issue 745333002: Remove implicit conversions from scoped_refptr to T* in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/metro_utils/metro_chrome_win.cc

diff --git a/chrome/browser/metro_utils/metro_chrome_win.cc b/chrome/browser/metro_utils/metro_chrome_win.cc

index d4985a6d54c147474e2c600a4f4eef788efc3d34..d20a680902d88c1ac7e08b79473e8541391115fd 100644

--- a/chrome/browser/metro_utils/metro_chrome_win.cc

+++ b/chrome/browser/metro_utils/metro_chrome_win.cc

@@ -41,7 +41,7 @@ bool ActivateMetroChrome() {

base::win::ScopedComPtr<IApplicationActivationManager> activation_manager;

HRESULT hr = activation_manager.CreateInstance(

CLSID_ApplicationActivationManager);

- if (!activation_manager) {

+ if (!activation_manager.get()) {

NOTREACHED() << "Failed to cocreate activation manager. Error: "

<< std::showbase << std::hex << hr;

return false;

« no previous file with comments | « no previous file | chrome/browser/shell_integration_win.cc » ('j') | chrome/browser/shell_integration_win.cc » ('J')