Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Unified Diff: breakpad/BUILD.gn

Issue 743813002: Take #2 at re-enabling breakpad in the Mac GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: build fix for symupload Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: breakpad/BUILD.gn
diff --git a/breakpad/BUILD.gn b/breakpad/BUILD.gn
index 5372d2b85243698fe920ffedab0a4f8b150e9015..62ff49fa4e4fb446ec83d50b812aa9b5a4421a68 100644
--- a/breakpad/BUILD.gn
+++ b/breakpad/BUILD.gn
@@ -227,6 +227,9 @@ if (current_toolchain == host_toolchain && is_mac) {
]
libs = [ "Foundation.framework" ]
+
+ configs -= [ "//build/config/compiler:chromium_code" ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
Nico 2014/11/20 17:45:38 Is there a way to mark all targets in this file as
}
}
@@ -255,10 +258,9 @@ if (is_mac) {
configs += [ ":internal_config" ]
- # TODO(GYP): TODO(dpranke): Fix the compile for this.
- sources -= [
- "src/client/mac/handler/dynamic_images.cc",
- ]
+ # There are some warnings in this code.
+ configs -= [ "//build/config/compiler:chromium_code" ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
}
executable("crash_inspector") {
@@ -287,6 +289,8 @@ if (is_mac) {
# TODO(GYP) this target has some mac_bundle_resources stuff.
# executable("crash_report_sender") {
# }
+ group("crash_report_sender") {
+ }
config("breakpad_config") {
include_dirs = [ "src/client/apple/Framework" ]
@@ -313,8 +317,7 @@ if (is_mac) {
deps = [
":utilities",
":crash_inspector",
- # TODO(GYP): Make this link
- #":crash_report_sender",
+ ":crash_report_sender",
]
}
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698