Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 742763002: scissor state on optstate (Closed)

Created:
6 years, 1 month ago by joshua.litt
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

scissor state on optstate waiting BUG=skia: Committed: https://skia.googlesource.com/skia/+/54e0c12a5ab2d83fe249dd199d6879e8c0f04404

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 1

Patch Set 3 : feedback inc #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -60 lines) Patch
M src/gpu/GrGpu.h View 1 3 chunks +1 line, -7 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 4 chunks +4 lines, -10 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 2 8 chunks +7 lines, -15 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 11 chunks +17 lines, -22 lines 0 comments Download
M src/gpu/GrOptDrawState.h View 1 4 chunks +15 lines, -1 line 0 comments Download
M src/gpu/GrOptDrawState.cpp View 1 4 chunks +5 lines, -1 line 0 comments Download
M src/gpu/GrTest.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
joshualitt
6 years, 1 month ago (2014-11-19 16:44:32 UTC) #2
bsalomon
lgtm w/ nit https://codereview.chromium.org/742763002/diff/20001/src/gpu/GrInOrderDrawBuffer.h File src/gpu/GrInOrderDrawBuffer.h (right): https://codereview.chromium.org/742763002/diff/20001/src/gpu/GrInOrderDrawBuffer.h#newcode119 src/gpu/GrInOrderDrawBuffer.h:119: Draw(const DrawInfo& info) : Cmd(kDraw_Cmd) , ...
6 years, 1 month ago (2014-11-19 16:50:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742763002/40001
6 years, 1 month ago (2014-11-19 17:12:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742763002/60001
6 years, 1 month ago (2014-11-19 17:27:45 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 17:38:56 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/54e0c12a5ab2d83fe249dd199d6879e8c0f04404

Powered by Google App Engine
This is Rietveld 408576698