Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 741833002: Store DM failures in an array, not a single string. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Store DM failures in an array, not a single string. This should fix the problem where a repeatedly failing test causes this assertion: ../../src/core/SkString.cpp:572: failed assertion "length >= 0 && length < SkToInt(kBufferSize)" Example output: 0 GMs x 7 configs, 2 tests, 0 pictures 0 tasks left, 100 failed Failures: test RTree: ../../tests/RTreeTest.cpp:77 0 != rtree.getCount() test RTree: ../../tests/RTreeTest.cpp:77 0 != rtree.getCount() test RTree: ../../tests/RTreeTest.cpp:77 0 != rtree.getCount() test RTree: ../../tests/RTreeTest.cpp:77 0 != rtree.getCount() < 95 lines elided > test RTree: ../../tests/RTreeTest.cpp:77 0 != rtree.getCount() 100 failures. BUG=skia: Committed: https://skia.googlesource.com/skia/+/008f1ea5812f6ebe42623c99b5e77dca423a4f1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M dm/DMTestTask.h View 2 chunks +3 lines, -7 lines 0 comments Download
M dm/DMTestTask.cpp View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein
6 years, 1 month ago (2014-11-19 21:28:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741833002/1
6 years, 1 month ago (2014-11-19 21:28:54 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-19 21:28:55 UTC) #5
bsalomon
lgtm
6 years, 1 month ago (2014-11-19 21:30:09 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 21:36:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/008f1ea5812f6ebe42623c99b5e77dca423a4f1c

Powered by Google App Engine
This is Rietveld 408576698