Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1537)

Unified Diff: dm/DMTestTask.h

Issue 741833002: Store DM failures in an array, not a single string. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dm/DMTestTask.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DMTestTask.h
diff --git a/dm/DMTestTask.h b/dm/DMTestTask.h
index 9a47b35f602502c7c163b2b30b35ac132fa03553..2ca31e38b5be650af623b2abe8cc1994f1fe2c7c 100644
--- a/dm/DMTestTask.h
+++ b/dm/DMTestTask.h
@@ -16,7 +16,7 @@ class TestReporter : public skiatest::Reporter {
public:
TestReporter() {}
- const char* failure() const { return fFailure.c_str(); }
+ const SkTArray<SkString>& failures() const { return fFailures; }
private:
virtual bool allowExtendedTest() const SK_OVERRIDE;
@@ -27,14 +27,10 @@ private:
SkString newFailure;
failure.getFailureString(&newFailure);
- // TODO: Better to store an array of failures?
- if (!fFailure.isEmpty()) {
- fFailure.append("\n\t\t");
- }
- fFailure.append(newFailure);
+ fFailures.push_back(newFailure);
}
- SkString fFailure;
+ SkTArray<SkString> fFailures;
};
class CpuTestTask : public CpuTask {
« no previous file with comments | « no previous file | dm/DMTestTask.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698