Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1805)

Unified Diff: dm/DMTestTask.cpp

Issue 741833002: Store DM failures in an array, not a single string. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/DMTestTask.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DMTestTask.cpp
diff --git a/dm/DMTestTask.cpp b/dm/DMTestTask.cpp
index ad0c3fb4f3d8cf3fbf0e45cf896f4f9ce55d604b..366087c351be1a7025f86cea69cbb34495f13a82 100644
--- a/dm/DMTestTask.cpp
+++ b/dm/DMTestTask.cpp
@@ -35,7 +35,10 @@ void CpuTestTask::draw() {
fTest->setReporter(&fTestReporter);
fTest->run();
if (!fTest->passed()) {
- this->fail(fTestReporter.failure());
+ const SkTArray<SkString>& failures = fTestReporter.failures();
+ for (int i = 0; i < failures.count(); i++) {
+ this->fail(failures[i].c_str());
+ }
}
}
@@ -44,7 +47,10 @@ void GpuTestTask::draw(GrContextFactory* grFactory) {
fTest->setReporter(&fTestReporter);
fTest->run();
if (!fTest->passed()) {
- this->fail(fTestReporter.failure());
+ const SkTArray<SkString>& failures = fTestReporter.failures();
+ for (int i = 0; i < failures.count(); i++) {
+ this->fail(failures[i].c_str());
+ }
}
}
« no previous file with comments | « dm/DMTestTask.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698