add SkImage::newSurface

add SkImage::newSurface

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/4af267b11964d4a8acdb232ac46094c84d890e88

[reed1, 2014-11-19 17:17:07]

reed@google.com changed reviewers:
+ bsalomon@google.com, senorblanco@google.com

[reed2, 2014-11-20 01:46:40]

The CQ bit was checked by reed@chromium.org

[commit-bot: I haz the power, 2014-11-20 01:47:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/741763002/20001

[commit-bot: I haz the power, 2014-11-20 01:47:22]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-11-20 07:47 UTC

[reed2, 2014-11-20 01:47:57]

reed@chromium.org changed reviewers:
+ fmalita@google.com

[reed2, 2014-11-20 01:47:58]

Florin is also looking at imagefilters and how they allocate their buffers.

[reed2, 2014-11-20 01:50:53]

The CQ bit was unchecked by reed@chromium.org

[reed2, 2014-11-20 01:50:58]

https://codereview.chromium.org/741763002/diff/20001/gm/surface.cpp
File gm/surface.cpp (right):

https://codereview.chromium.org/741763002/diff/20001/gm/surface.cpp#newcode132
gm/surface.cpp:132: SkAutoTUnref<SkSurface> surf(canvas->newSurface(info,
&props));
Should just pass NULL for this props. Then we can use surf->surfaceProps() to
know what to pass to image->newSurface..

[reed2, 2014-11-20 01:56:54]

https://codereview.chromium.org/741763002/diff/20001/gm/surface.cpp
File gm/surface.cpp (right):

https://codereview.chromium.org/741763002/diff/20001/gm/surface.cpp#newcode133
gm/surface.cpp:133: if (!surf.get()) return;
need to call newraster, or disable pictures during DM... or decide that canvas
should just return raster when it is backed by picture?

[reed1, 2014-11-20 19:00:19]

https://codereview.chromium.org/741763002/diff/20001/gm/surface.cpp
File gm/surface.cpp (right):

https://codereview.chromium.org/741763002/diff/20001/gm/surface.cpp#newcode132
gm/surface.cpp:132: SkAutoTUnref<SkSurface> surf(canvas->newSurface(info,
&props));
On 2014/11/20 01:50:58, reed2 wrote:
> Should just pass NULL for this props. Then we can use surf->surfaceProps() to
> know what to pass to image->newSurface..

Done.

https://codereview.chromium.org/741763002/diff/20001/gm/surface.cpp#newcode133
gm/surface.cpp:133: if (!surf.get()) return;
On 2014/11/20 01:56:54, reed2 wrote:
> need to call newraster, or disable pictures during DM... or decide that canvas
> should just return raster when it is backed by picture?

Done.

[reed1, 2014-11-20 19:00:58]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-11-20 19:01:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/741763002/40001

[commit-bot: I haz the power, 2014-11-20 19:01:52]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-11-21 01:01 UTC

[commit-bot: I haz the power, 2014-11-20 19:03:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-20 19:03:47]

Try jobs failed on following builders:
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Cl...)
  Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GC...)

[reed1, 2014-11-20 19:09:55]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-11-20 19:10:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/741763002/60001

[commit-bot: I haz the power, 2014-11-20 19:10:53]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-11-21 01:10 UTC

[commit-bot: I haz the power, 2014-11-20 19:14:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-20 19:14:04]

Try jobs failed on following builders:
  Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GC...)

[bsalomon, 2014-11-21 14:45:44]

https://codereview.chromium.org/741763002/diff/60001/src/image/SkImage_Gpu.cpp
File src/image/SkImage_Gpu.cpp (right):

https://codereview.chromium.org/741763002/diff/60001/src/image/SkImage_Gpu.cp...
src/image/SkImage_Gpu.cpp:73: const int sampleCount = 0;  // TODO: extract this
from this image...
why not just do this as part of this CL?

[reed1, 2014-11-21 16:33:06]

https://codereview.chromium.org/741763002/diff/60001/src/image/SkImage_Gpu.cpp
File src/image/SkImage_Gpu.cpp (right):

https://codereview.chromium.org/741763002/diff/60001/src/image/SkImage_Gpu.cp...
src/image/SkImage_Gpu.cpp:73: const int sampleCount = 0;  // TODO: extract this
from this image...
On 2014/11/21 14:45:44, bsalomon wrote:
> why not just do this as part of this CL?

Done.

[reed1, 2014-11-21 16:34:26]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-11-21 16:35:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/741763002/100001

[commit-bot: I haz the power, 2014-11-21 16:35:29]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-11-21 22:35 UTC

[reed1, 2014-11-21 16:42:40]

PTAL

[bsalomon, 2014-11-21 16:43:41]

lgtm, but maybe should clarify somewhere that image's sample count is not the
sample count of the texture it owns but is just the sample count it should use
to create new surfaces.

[commit-bot: I haz the power, 2014-11-21 16:46:42]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/4af267b11964d4a8acdb232ac46094c84d890e88