Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 740603002: win: use /maxilksize on link to avoid LNK1248 'exceeds maximum allowable size (80000000)' (Closed)

Created:
6 years, 1 month ago by scottmg
Modified:
6 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

win: use /maxilksize on link to avoid LNK1248 'exceeds maximum allowable size (80000000)' This error is happening more frequently on various configurations and targets after the switch to VS2013 Update 4. MS dev rel suggested the flag as a workaround and it appears to alleviate the problem. This also reverts https://codereview.chromium.org/725173003 as it is no longer required. R=thakis@chromium.org BUG=432748 Committed: https://crrev.com/567a3fdd294e90aa5c4c0763924b7c0838e65dea Cr-Commit-Position: refs/heads/master@{#304736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scottmg
6 years, 1 month ago (2014-11-18 23:49:27 UTC) #1
Nico
black magic lgtm
6 years, 1 month ago (2014-11-18 23:50:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740603002/1
6 years, 1 month ago (2014-11-19 00:04:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-19 01:47:41 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 01:49:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/567a3fdd294e90aa5c4c0763924b7c0838e65dea
Cr-Commit-Position: refs/heads/master@{#304736}

Powered by Google App Engine
This is Rietveld 408576698