Issue 725173003: Disable incremental linking on win x64 unit_tests, causing link failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 725173003: Disable incremental linking on win x64 unit_tests, causing link failures (Closed)

Created:
6 years, 1 month ago by scottmg

Modified:
6 years, 1 month ago

Reviewers:
rmsousa

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Disable incremental linking on win x64 unit_tests, causing link failures This reduces the size of the binary a bit. I'll file an upstream bug against MS to see if they can improve size a bit, as there's no way that should be exceeding 2G binary size (not incl symbols). TBR=rmsousa@chromium.org BUG=432748 Committed: https://chromium.googlesource.com/chromium/src/+/973c7a164ad3f53d263a5a6bf1fffa662e37a55d

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/chrome_tests_unit.gypi	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/973c7a164ad3f53d263a5a6bf1fffa662e37a55d Cr-Commit-Position: refs/heads/master@{#304355}

6 years, 1 month ago (2014-11-15 04:55:36 UTC) #2

scottmg

6 years, 1 month ago (2014-11-15 04:55:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
973c7a164ad3f53d263a5a6bf1fffa662e37a55d (presubmit successful).