Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 740083003: Add unsafe ES3 APIs to command buffer: glTexStorage3D (Closed)

Created:
6 years ago by Zhenyao Mo
Modified:
6 years ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cb
Project:
chromium
Visibility:
Public.

Description

Add unsafe ES3 APIs to command buffer: glTexStorage3D Also, we check in GLES3 header files to third_party/khronos. BUG=429053 TEST=gpu_unittests R=bajones@chromium.org,kbr@chromium.org TBR=sievers@chromium.org Committed: https://crrev.com/e368fbf671d3e9ea227ea9f0da82093d94a16f13 Cr-Commit-Position: refs/heads/master@{#305946}

Patch Set 1 : rebase #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2657 lines, -141 lines) Patch
M gpu/GLES2/gl2chromium_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 3 chunks +14 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 2 chunks +13 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 chunk +12 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 1 chunk +33 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 chunk +11 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 chunk +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 chunk +10 lines, -0 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 chunk +64 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 chunk +18 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +113 lines, -112 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 86 chunks +667 lines, -14 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 chunk +33 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 2 chunks +12 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 2 chunks +7 lines, -0 lines 0 comments Download
A + third_party/khronos/GLES3/gl3.h View 3 chunks +420 lines, -7 lines 0 comments Download
A third_party/khronos/GLES3/gl31.h View 1 chunk +1184 lines, -0 lines 0 comments Download
A + third_party/khronos/GLES3/gl3platform.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/khronos/README.chromium View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Zhenyao Mo
Please take a look. Again, this CL only adds one function, but at the same ...
6 years ago (2014-11-26 18:08:26 UTC) #2
bajones
LGTM with one nit https://codereview.chromium.org/740083003/diff/40001/third_party/khronos/README.chromium File third_party/khronos/README.chromium (right): https://codereview.chromium.org/740083003/diff/40001/third_party/khronos/README.chromium#newcode15 third_party/khronos/README.chromium:15: for GLES2/* amd GLES3/*. Typo: ...
6 years ago (2014-11-26 18:19:23 UTC) #3
Zhenyao Mo
https://codereview.chromium.org/740083003/diff/40001/third_party/khronos/README.chromium File third_party/khronos/README.chromium (right): https://codereview.chromium.org/740083003/diff/40001/third_party/khronos/README.chromium#newcode15 third_party/khronos/README.chromium:15: for GLES2/* amd GLES3/*. On 2014/11/26 18:19:22, bajones wrote: ...
6 years ago (2014-11-26 18:21:40 UTC) #4
no sievers
lgtm
6 years ago (2014-11-26 18:27:20 UTC) #7
Zhenyao Mo
kbr: please take a look. Need your owner approval for third_party/khronos. On Wed, Nov 26, ...
6 years ago (2014-11-26 19:33:35 UTC) #8
Ken Russell (switch to Gerrit)
Excellent. third_party/khronos lgtm
6 years ago (2014-11-27 02:05:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740083003/60001
6 years ago (2014-11-27 02:13:18 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:60001)
6 years ago (2014-11-27 02:16:05 UTC) #12
commit-bot: I haz the power
6 years ago (2014-11-27 02:16:49 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e368fbf671d3e9ea227ea9f0da82093d94a16f13
Cr-Commit-Position: refs/heads/master@{#305946}

Powered by Google App Engine
This is Rietveld 408576698