[NaCl SDK] Fix mysterious gtest failure in Html5FsTest::OpenForCreate

[NaCl SDK] Fix mysterious gtest failure in Html5FsTest::OpenForCreate

The failure seems to have been triggered from the recent
gtest update.  The exact revision seems to be:
https://code.google.com/p/googletest/source/detail?r=693

The issue only effects builds made with our older
gcc 4.4 toolchain. Neither asan nor valgrind report any
issues with the linux run of this test, and PNaCl build
also passes just fine so I'm assuming is a compiler bug
in the older toolchain.

The fix I found was to use "const char*" over "char []"
for local string constants.  In fact just adding a const
alone and leaving the [] syntax also fixes the issue.

Most likely there is an underlying compiler bug that
still needs to be addressed.

BUG=434821
Committed: https://crrev.com/ac5b4307414e447002ed67a038cad27264a5cce5
Cr-Commit-Position: refs/heads/master@{#304959}

[Sam Clegg, 2014-11-19 20:05:42]

sbc@chromium.org changed reviewers:
+ binji@chromium.org

[binji, 2014-11-19 21:17:03]

strange.
lgtm

[Sam Clegg, 2014-11-19 21:35:52]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2014-11-19 21:37:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/740023002/1

[Sam Clegg, 2014-11-19 22:05:57]

The CQ bit was unchecked by sbc@chromium.org

[Sam Clegg, 2014-11-19 22:06:33]

Just saw some more errors just like this in naclports, so we probably need to
look into what change in gtest in tickling the compiler.

[Sam Clegg, 2014-11-20 02:28:45]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2014-11-20 02:29:38]

On 2014/11/19 22:06:33, Sam Clegg wrote:
> Just saw some more errors just like this in naclports, so we probably need to
> look into what change in gtest in tickling the compiler.

Submitting this to green the tree while the underlying issue is investigated.

[commit-bot: I haz the power, 2014-11-20 02:29:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/740023002/1

[commit-bot: I haz the power, 2014-11-20 02:31:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-20 02:31:48]

Patchset 1 (id:??) landed as
https://crrev.com/ac5b4307414e447002ed67a038cad27264a5cce5
Cr-Commit-Position: refs/heads/master@{#304959}