[NaCl SDK] Fix mysterious gtest failure in Html5FsTest::OpenForCreate

native_client_sdk/src/tests/nacl_io_test/html5_fs_test.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <errno.h>
 #include <fcntl.h>
 
 #include <set>
 #include <string>
 
@@ skipping 233 matching lines @@
   StringMap_t map;
   ScopedRef<Html5FsForTesting> fs(new Html5FsForTesting(map, &ppapi_));
 
   EXPECT_FALSE(fs->Exists("/foo"));
 
   Path path("/foo");
   ScopedNode node;
   ASSERT_EQ(0, fs->Open(path, O_CREAT | O_RDWR, &node));
 
   // Write some data.
-  char contents[] = "contents";
+  const char* contents = "contents";
   int bytes_written = 0;
-  EXPECT_EQ(0, node->Write(HandleAttr(), &contents[0], strlen(contents),
+  EXPECT_EQ(0, node->Write(HandleAttr(), contents, strlen(contents),
                            &bytes_written));
   EXPECT_EQ(strlen(contents), bytes_written);
 
   // Create again.
   ASSERT_EQ(0, fs->Open(path, O_CREAT, &node));
 
   // Check that the file still has data.
   off_t size;
   EXPECT_EQ(0, node->GetSize(&size));
   EXPECT_EQ(strlen(contents), size);
 
   // Open exclusively.
   EXPECT_EQ(EEXIST, fs->Open(path, O_CREAT | O_EXCL, &node));
 
   // Try to truncate without write access.
   EXPECT_EQ(EINVAL, fs->Open(path, O_CREAT | O_TRUNC, &node));
 
   // Open and truncate.
   ASSERT_EQ(0, fs->Open(path, O_CREAT | O_TRUNC | O_WRONLY, &node));
 
   // File should be empty.
   EXPECT_EQ(0, node->GetSize(&size));
   EXPECT_EQ(0, size);
 }
 
 TEST_F(Html5FsTest, Read) {
-  const char contents[] = "contents";
+  const char* contents = "contents";
   ASSERT_TRUE(
       ppapi_html5_.filesystem_template()->AddFile("/file", contents, NULL));
   ASSERT_TRUE(ppapi_html5_.filesystem_template()->AddDirectory("/dir", NULL));
   StringMap_t map;
   ScopedRef<Html5FsForTesting> fs(new Html5FsForTesting(map, &ppapi_));
 
   ScopedNode node;
   ASSERT_EQ(0, fs->Open(Path("/file"), O_RDONLY, &node));
 
   char buffer[10] = {0};
@@ skipping 21 matching lines @@
   ASSERT_EQ(EACCES,
             node->Write(attr, &buffer[0], sizeof(buffer), &bytes_written));
   ASSERT_EQ(0, bytes_written);
 
   // Reading from a directory should fail.
   ASSERT_EQ(0, fs->Open(Path("/dir"), O_RDONLY, &node));
   ASSERT_EQ(EISDIR, node->Read(attr, &buffer[0], sizeof(buffer), &bytes_read));
 }
 
 TEST_F(Html5FsTest, Write) {
-  const char contents[] = "contents";
+  const char* contents = "contents";
   EXPECT_TRUE(
       ppapi_html5_.filesystem_template()->AddFile("/file", contents, NULL));
   EXPECT_TRUE(ppapi_html5_.filesystem_template()->AddDirectory("/dir", NULL));
 
   StringMap_t map;
   ScopedRef<Html5FsForTesting> fs(new Html5FsForTesting(map, &ppapi_));
 
   ScopedNode node;
   ASSERT_EQ(0, fs->Open(Path("/file"), O_WRONLY, &node));
 
@@ skipping 20 matching lines @@
 
   // Writing to a directory should fail.
   EXPECT_EQ(0, fs->Open(Path("/dir"), O_RDWR, &node));
   EXPECT_EQ(EISDIR, node->Write(attr, &buffer[0], sizeof(buffer), &bytes_read));
 }
 
 TEST_F(Html5FsTest, GetStat) {
   const int creation_time = 1000;
   const int access_time = 2000;
   const int modified_time = 3000;
-  const char contents[] = "contents";
+  const char* contents = "contents";
 
   // Create fake file.
   FakeHtml5FsNode* fake_node;
   EXPECT_TRUE(ppapi_html5_.filesystem_template()->AddFile(
       "/file", contents, &fake_node));
   fake_node->set_creation_time(creation_time);
   fake_node->set_last_access_time(access_time);
   fake_node->set_last_modified_time(modified_time);
 
   // Create fake directory.
@@ skipping 38 matching lines @@
 
   // Test Get* and Isa* methods.
   EXPECT_EQ(0, node->GetSize(&size));
   EXPECT_EQ(0, size);
   EXPECT_TRUE(node->IsaDir());
   EXPECT_FALSE(node->IsaFile());
   EXPECT_EQ(ENOTTY, node->Isatty());
 }
 
 TEST_F(Html5FsTest, FTruncate) {
-  const char contents[] = "contents";
+  const char* contents = "contents";
   EXPECT_TRUE(
       ppapi_html5_.filesystem_template()->AddFile("/file", contents, NULL));
   EXPECT_TRUE(ppapi_html5_.filesystem_template()->AddDirectory("/dir", NULL));
 
   StringMap_t map;
   ScopedRef<Html5FsForTesting> fs(new Html5FsForTesting(map, &ppapi_));
 
   ScopedNode node;
   ASSERT_EQ(0, fs->Open(Path("/file"), O_RDWR, &node));
 
@@ skipping 22 matching lines @@
 
 TEST_F(Html5FsTest, Chmod) {
   StringMap_t map;
   ScopedRef<Html5FsForTesting> fs(new Html5FsForTesting(map, &ppapi_));
   ScopedNode node;
   ASSERT_EQ(0, fs->Open(Path("/"), O_RDONLY, &node));
   ASSERT_EQ(0, node->Fchmod(0777));
 }
 
 TEST_F(Html5FsTest, GetDents) {
-  const char contents[] = "contents";
+  const char* contents = "contents";
   EXPECT_TRUE(
       ppapi_html5_.filesystem_template()->AddFile("/file", contents, NULL));
 
   StringMap_t map;
   ScopedRef<Html5FsForTesting> fs(new Html5FsForTesting(map, &ppapi_));
 
   ScopedNode root;
   ASSERT_EQ(0, fs->Open(Path("/"), O_RDONLY, &root));
 
   ScopedNode node;
@@ skipping 67 matching lines @@
         EXPECT_EQ(dirents[i].d_ino, file2_ino);
       }
     }
 
     EXPECT_EQ(1, dirnames.count("file"));
     EXPECT_EQ(1, dirnames.count("file2"));
     EXPECT_EQ(1, dirnames.count("."));
     EXPECT_EQ(1, dirnames.count(".."));
   }
 }