Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2057)

Unified Diff: native_client_sdk/src/tests/nacl_io_test/html5_fs_test.cc

Issue 740023002: [NaCl SDK] Fix mysterious gtest failure in Html5FsTest::OpenForCreate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/tests/nacl_io_test/html5_fs_test.cc
diff --git a/native_client_sdk/src/tests/nacl_io_test/html5_fs_test.cc b/native_client_sdk/src/tests/nacl_io_test/html5_fs_test.cc
index 95e349b39e7eaf7ea9c461f9089be191d4b8bc5b..3cb8d1646da9cabfe925fcf3763922360698e164 100644
--- a/native_client_sdk/src/tests/nacl_io_test/html5_fs_test.cc
+++ b/native_client_sdk/src/tests/nacl_io_test/html5_fs_test.cc
@@ -251,9 +251,9 @@ TEST_F(Html5FsTest, OpenForCreate) {
ASSERT_EQ(0, fs->Open(path, O_CREAT | O_RDWR, &node));
// Write some data.
- char contents[] = "contents";
+ const char* contents = "contents";
int bytes_written = 0;
- EXPECT_EQ(0, node->Write(HandleAttr(), &contents[0], strlen(contents),
+ EXPECT_EQ(0, node->Write(HandleAttr(), contents, strlen(contents),
&bytes_written));
EXPECT_EQ(strlen(contents), bytes_written);
@@ -280,7 +280,7 @@ TEST_F(Html5FsTest, OpenForCreate) {
}
TEST_F(Html5FsTest, Read) {
- const char contents[] = "contents";
+ const char* contents = "contents";
ASSERT_TRUE(
ppapi_html5_.filesystem_template()->AddFile("/file", contents, NULL));
ASSERT_TRUE(ppapi_html5_.filesystem_template()->AddDirectory("/dir", NULL));
@@ -322,7 +322,7 @@ TEST_F(Html5FsTest, Read) {
}
TEST_F(Html5FsTest, Write) {
- const char contents[] = "contents";
+ const char* contents = "contents";
EXPECT_TRUE(
ppapi_html5_.filesystem_template()->AddFile("/file", contents, NULL));
EXPECT_TRUE(ppapi_html5_.filesystem_template()->AddDirectory("/dir", NULL));
@@ -363,7 +363,7 @@ TEST_F(Html5FsTest, GetStat) {
const int creation_time = 1000;
const int access_time = 2000;
const int modified_time = 3000;
- const char contents[] = "contents";
+ const char* contents = "contents";
// Create fake file.
FakeHtml5FsNode* fake_node;
@@ -422,7 +422,7 @@ TEST_F(Html5FsTest, GetStat) {
}
TEST_F(Html5FsTest, FTruncate) {
- const char contents[] = "contents";
+ const char* contents = "contents";
EXPECT_TRUE(
ppapi_html5_.filesystem_template()->AddFile("/file", contents, NULL));
EXPECT_TRUE(ppapi_html5_.filesystem_template()->AddDirectory("/dir", NULL));
@@ -465,7 +465,7 @@ TEST_F(Html5FsTest, Chmod) {
}
TEST_F(Html5FsTest, GetDents) {
- const char contents[] = "contents";
+ const char* contents = "contents";
EXPECT_TRUE(
ppapi_html5_.filesystem_template()->AddFile("/file", contents, NULL));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698