Determine connection type in NetworkChangeNotifierLinux.

net/base/net_util_linux.h

Index: net/base/net_util_linux.h
diff --git a/net/base/net_util_linux.h b/net/base/net_util_linux.h
index 340c3802eea080878a82db44a6b989a6c329971b..7b50fd630e81dcefc885e2ded6b61fff7f1fe177 100644
--- a/net/base/net_util_linux.h
+++ b/net/base/net_util_linux.h
@@ -18,6 +18,18 @@ namespace internal {
 typedef char* (*GetInterfaceNameFunction)(unsigned int interface_index,
                                           char* ifname);
 
+// Returns the name for the interface with interface index |interface_index|.

[pauljensen, 2015/01/13 13:14:31]

This should mention how |buf| relates to the return value.

[derekjchow1, 2015/01/13 21:32:39]

Done.

+// |buf| should be a pointer to an array of size IFNAMSIZ. This function acts
+// like if_indextoname which cannot be used as net/if.h cannot be mixed with
+// linux/if.h. We'll stick with exclusively talking to the kernel and not the
+// C library.
+char* GetInterfaceName(unsigned int interface_index, char* buf);
+
+// Gets the connection type for interface |ifname| by checking for wireless
+// extensions.
+NetworkChangeNotifier::ConnectionType GetInterfaceConnectionType(

[pauljensen, 2015/01/13 13:14:31]

This header should include "net/base/network_change_notifier.h"

[derekjchow1, 2015/01/13 21:32:39]

Done.

+    std::string ifname);

[pauljensen, 2015/01/13 13:14:30]

I think this should be a const reference, not passed by value.

[pauljensen, 2015/01/13 13:14:31]

This header should include <string>

[derekjchow1, 2015/01/13 21:32:39]

Done.

[derekjchow1, 2015/01/13 21:32:39]

Done.

+
 NET_EXPORT bool GetNetworkListImpl(
     NetworkInterfaceList* networks,
     int policy,