Determine connection type in NetworkChangeNotifierLinux.

net/base/net_util_linux.h

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_NET_UTIL_LINUX_H_
 #define NET_BASE_NET_UTIL_LINUX_H_
 
 // This file is only used to expose some of the internals
 // of net_util_linux.cc to tests.
 
 #include "base/containers/hash_tables.h"
 #include "net/base/address_tracker_linux.h"
 #include "net/base/net_util.h"
 
 namespace net {
 namespace internal {
 
 typedef char* (*GetInterfaceNameFunction)(unsigned int interface_index,
                                           char* ifname);
 
+// Returns the name for the interface with interface index |interface_index|.

[pauljensen, 2015/01/13 13:14:31]

This should mention how |buf| relates to the return value.

[derekjchow1, 2015/01/13 21:32:39]

Done.

+// |buf| should be a pointer to an array of size IFNAMSIZ. This function acts
+// like if_indextoname which cannot be used as net/if.h cannot be mixed with
+// linux/if.h. We'll stick with exclusively talking to the kernel and not the
+// C library.
+char* GetInterfaceName(unsigned int interface_index, char* buf);
+
+// Gets the connection type for interface |ifname| by checking for wireless
+// extensions.
+NetworkChangeNotifier::ConnectionType GetInterfaceConnectionType(

[pauljensen, 2015/01/13 13:14:31]

This header should include "net/base/network_change_notifier.h"

[derekjchow1, 2015/01/13 21:32:39]

Done.

+    std::string ifname);

[pauljensen, 2015/01/13 13:14:30]

I think this should be a const reference, not passed by value.

[pauljensen, 2015/01/13 13:14:31]

This header should include <string>

[derekjchow1, 2015/01/13 21:32:39]

Done.

[derekjchow1, 2015/01/13 21:32:39]

Done.

+
 NET_EXPORT bool GetNetworkListImpl(
     NetworkInterfaceList* networks,
     int policy,
     const base::hash_set<int>& online_links,
     const internal::AddressTrackerLinux::AddressMap& address_map,
     GetInterfaceNameFunction get_interface_name);
 
 }  // namespace internal
 }  // namespace net
 
 #endif  // NET_BASE_NET_UTIL_LINUX_H_