Determine connection type in NetworkChangeNotifierLinux.

net/base/address_tracker_linux.cc

Index: net/base/address_tracker_linux.cc
diff --git a/net/base/address_tracker_linux.cc b/net/base/address_tracker_linux.cc
index 27dd2019ab0dffd6392dee105b7ae11ba7b6e138..0787c84fbe296bfd1fe655a27ed61c979ad16b14 100644
--- a/net/base/address_tracker_linux.cc
+++ b/net/base/address_tracker_linux.cc
@@ -11,6 +11,11 @@
 #include "base/logging.h"
 #include "base/posix/eintr_wrapper.h"
 #include "base/threading/thread_restrictions.h"
+#include "net/base/ip_endpoint.h"
+#include "net/base/net_util_linux.h"
+#include "net/base/net_util_posix.h"
+
+#include <arpa/inet.h>

[pauljensen, 2015/01/13 13:14:29]

Shouldn't system headers go above Chromium header includes?

[derekjchow1, 2015/01/13 21:32:35]

Done.

 
 namespace net {
 namespace internal {
@@ -76,25 +81,6 @@ bool GetAddress(const struct nlmsghdr* header,
   return true;
 }
 
-// Returns the name for the interface with interface index |interface_index|.
-// The return value points to a function-scoped static so it may be changed by
-// subsequent calls. This function could be replaced with if_indextoname() but
-// net/if.h cannot be mixed with linux/if.h so we'll stick with exclusively
-// talking to the kernel and not the C library.
-const char* GetInterfaceName(int interface_index) {
-  int ioctl_socket = socket(AF_INET, SOCK_DGRAM, 0);
-  if (ioctl_socket < 0)
-    return "";
-  static struct ifreq ifr;
-  memset(&ifr, 0, sizeof(ifr));
-  ifr.ifr_ifindex = interface_index;
-  int rv = ioctl(ioctl_socket, SIOCGIFNAME, &ifr);
-  close(ioctl_socket);
-  if (rv != 0)
-    return "";
-  return ifr.ifr_name;
-}
-
 }  // namespace
 
 AddressTrackerLinux::AddressTrackerLinux()
@@ -103,9 +89,9 @@ AddressTrackerLinux::AddressTrackerLinux()
       link_callback_(base::Bind(&base::DoNothing)),
       tunnel_callback_(base::Bind(&base::DoNothing)),
       netlink_fd_(-1),
-      is_offline_(true),
-      is_offline_initialized_(false),
-      is_offline_initialized_cv_(&is_offline_lock_),
+      is_initialized_(false),
+      is_initialized_cv_(&connection_type_lock_),
+      current_connection_type_(NetworkChangeNotifier::CONNECTION_NONE),
       tracking_(false) {
 }
 
@@ -117,9 +103,9 @@ AddressTrackerLinux::AddressTrackerLinux(const base::Closure& address_callback,
       link_callback_(link_callback),
       tunnel_callback_(tunnel_callback),
       netlink_fd_(-1),
-      is_offline_(true),
-      is_offline_initialized_(false),
-      is_offline_initialized_cv_(&is_offline_lock_),
+      is_initialized_(false),
+      is_initialized_cv_(&connection_type_lock_),
+      current_connection_type_(NetworkChangeNotifier::CONNECTION_NONE),
       tracking_(true) {
   DCHECK(!address_callback.is_null());
   DCHECK(!link_callback.is_null());
@@ -203,9 +189,9 @@ void AddressTrackerLinux::Init() {
   // Consume pending message to populate links_online_, but don't notify.
   ReadMessages(&address_changed, &link_changed, &tunnel_changed);
   {
-    AddressTrackerAutoLock lock(*this, is_offline_lock_);
-    is_offline_initialized_ = true;
-    is_offline_initialized_cv_.Signal();
+    AddressTrackerAutoLock lock(*this, connection_type_lock_);
+    is_initialized_ = true;
+    is_initialized_cv_.Signal();
   }
 
   if (tracking_) {
@@ -221,10 +207,10 @@ void AddressTrackerLinux::Init() {
 
 void AddressTrackerLinux::AbortAndForceOnline() {
   CloseSocket();
-  AddressTrackerAutoLock lock(*this, is_offline_lock_);
-  is_offline_ = false;
-  is_offline_initialized_ = true;
-  is_offline_initialized_cv_.Signal();
+  AddressTrackerAutoLock lock(*this, connection_type_lock_);
+  current_connection_type_ = NetworkChangeNotifier::CONNECTION_UNKNOWN;
+  is_initialized_ = true;
+  is_initialized_cv_.Signal();
 }
 
 AddressTrackerLinux::AddressMap AddressTrackerLinux::GetAddressMap() const {
@@ -241,15 +227,12 @@ NetworkChangeNotifier::ConnectionType
 AddressTrackerLinux::GetCurrentConnectionType() {
   // http://crbug.com/125097
   base::ThreadRestrictions::ScopedAllowWait allow_wait;
-  AddressTrackerAutoLock lock(*this, is_offline_lock_);
-  // Make sure the initial offline state is set before returning.
-  while (!is_offline_initialized_) {
-    is_offline_initialized_cv_.Wait();
+  AddressTrackerAutoLock lock(*this, connection_type_lock_);
+  // Make sure the initial connection type is set before returning.
+  while (!is_initialized_) {
+    is_initialized_cv_.Wait();
   }
-  // TODO(droger): Return something more detailed than CONNECTION_UNKNOWN.
-  // http://crbug.com/160537
-  return is_offline_ ? NetworkChangeNotifier::CONNECTION_NONE :
-                       NetworkChangeNotifier::CONNECTION_UNKNOWN;
+  return current_connection_type_;
 }
 
 void AddressTrackerLinux::ReadMessages(bool* address_changed,
@@ -279,14 +262,10 @@ void AddressTrackerLinux::ReadMessages(bool* address_changed,
     }
     HandleMessage(buffer, rv, address_changed, link_changed, tunnel_changed);
   }
-  if (*link_changed) {
-    bool is_offline;
-    {
-      AddressTrackerAutoLock lock(*this, online_links_lock_);
-      is_offline = online_links_.empty();
-    }
-    AddressTrackerAutoLock lock(*this, is_offline_lock_);
-    is_offline_ = is_offline;
+  if (*link_changed || *address_changed) {
+    NetworkChangeNotifier::ConnectionType type = GetNewConnectionType();
+    AddressTrackerAutoLock lock(*this, connection_type_lock_);
+    current_connection_type_ = type;
   }
 }
 
@@ -403,7 +382,25 @@ void AddressTrackerLinux::CloseSocket() {
 
 bool AddressTrackerLinux::IsTunnelInterface(const struct ifinfomsg* msg) const {
   // Linux kernel drivers/net/tun.c uses "tun" name prefix.
-  return strncmp(get_interface_name_(msg->ifi_index), "tun", 3) == 0;
+  char buf[IFNAMSIZ] = {0};
+  return strncmp(get_interface_name_(msg->ifi_index, buf), "tun", 3) == 0;
+}
+
+NetworkChangeNotifier::ConnectionType
+AddressTrackerLinux::GetNewConnectionType() {
+  base::hash_set<int> online_links = GetOnlineLinks();
+  AddressTrackerLinux::AddressMap address_map = GetAddressMap();
+  NetworkInterfaceList networks;
+  if (!GetNetworkListImpl(&networks, 0, online_links, address_map,
+                          get_interface_name_) ||
+      networks.empty())

[pauljensen, 2015/01/13 13:14:29]

I feel like this needs curly braces as the condition is longer than one line.

[derekjchow1, 2015/01/13 21:32:35]

Done.

+    return NetworkChangeNotifier::CONNECTION_NONE;
+
+  for (unsigned int i = 1; i < networks.size(); i++) {

[pauljensen, 2015/01/13 13:14:29]

Can this code be moved to a host-independent location? For example:
https://codereview.chromium.org/298023005/diff/130001/net/base/network_change...
https://codereview.chromium.org/298023005/diff/130001/net/base/network_change...

[derekjchow1, 2015/01/13 21:32:35]

Added "ConnectionTypeFromInterfaceList" to net_util.h. I also added a new unit
test (based on this
https://codereview.chromium.org/298023005/patch/130001/140003).

+    if (networks[i].type != networks[0].type)
+      return NetworkChangeNotifier::CONNECTION_UNKNOWN;
+  }
+  return networks[0].type;
 }
 
 AddressTrackerLinux::AddressTrackerAutoLock::AddressTrackerAutoLock(