tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py - Issue 739623005: [Telemetry] Resolve errors due to new pylint checker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py

Issue 739623005: [Telemetry] Resolve errors due to new pylint checker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready to land Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py ('k') | tools/telemetry/telemetry/core/backends/chrome/inspector_network.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py

index af0fbd33a7409b49f62ccb061f2e5a4c2573928d..908efb793dbcc4ec2bd2db6ae0209bd074fbaa7d 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py

@@ -8,6 +8,7 @@ import logging

from telemetry.core import platform as platform_module

from telemetry.core import browser

+from telemetry.core import browser_finder_exceptions

from telemetry.core import possible_browser

from telemetry.core.platform import cros_device

from telemetry.core.platform import cros_interface

@@ -126,8 +127,7 @@ def FindAllAvailableBrowsers(finder_options):

logging.warn('There, that was easy!')

logging.warn('')

logging.warn('P.S. Please, tell your manager how INANE this is.')

- from telemetry.core import browser_finder

- raise browser_finder.BrowserFinderException(str(ex))

+ raise browser_finder_exceptions.BrowserFinderException(str(ex))

return [PossibleCrOSBrowser('cros-chrome', finder_options, platform,

is_guest=False),