tools/telemetry/telemetry/core/backends/chrome/inspector_network.py - Issue 739623005: [Telemetry] Resolve errors due to new pylint checker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/inspector_network.py

Issue 739623005: [Telemetry] Resolve errors due to new pylint checker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready to land Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py ('k') | tools/telemetry/telemetry/core/backends/chrome/inspector_network_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/inspector_network.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/inspector_network.py b/tools/telemetry/telemetry/core/backends/chrome/inspector_network.py

index 32b4e8d050b0803283b7a9065c9e23001678b57c..2272cec95a19e0eba1b699fb854021f8a8851cc6 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/inspector_network.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/inspector_network.py

@@ -115,6 +115,7 @@ class InspectorNetworkResponseData(object):

params['requestId'] = event.args['requestId']

params['response'] = event.args['response']

recorded = InspectorNetworkResponseData(None, params)

+ # pylint: disable=protected-access

recorded._body = event.args['body']

recorded._base64_encoded = event.args['base64_encoded_body']

recorded._served_from_cache = event.args['served_from_cache']

@@ -184,7 +185,7 @@ class InspectorNetwork(object):

def GetHTTPResponseBody(self, request_id, timeout=60):

try:

- res = self._inspector_backend.SyncRequest({

+ res = self._inspector_backend.SyncRequest({

'method': 'Network.getResponseBody',

'params': {

'requestId': request_id,

@@ -204,7 +205,7 @@ class InspectorNetwork(object):

pass

@property

- def timeline_recorder (self):

+ def timeline_recorder(self):

if not self._timeline_recorder:

self._timeline_recorder = TimelineRecorder(self)

return self._timeline_recorder