tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py - Issue 739623005: [Telemetry] Resolve errors due to new pylint checker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

Issue 739623005: [Telemetry] Resolve errors due to new pylint checker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready to land Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/chrome_browser_options.py ('k') | tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

index 77b28fc25fa7c8c2aa58c44c7e796207a6d5e5b7..d4b5c5549ae80445e96bc8d8b0dc28d6d87f2114 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

@@ -22,16 +22,11 @@ class CrOSBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

supports_extensions=not is_guest,

browser_options=browser_options,

output_profile_path=None, extensions_to_load=extensions_to_load)

+ assert browser_options.IsCrosBrowserOptions()

# Initialize fields so that an explosion during init doesn't break in Close.

self._cri = cri

self._is_guest = is_guest

self._forwarder = None

- from telemetry.core.backends.chrome import chrome_browser_options

- assert isinstance(browser_options,

- chrome_browser_options.CrosBrowserOptions)

self.wpr_port_pairs = forwarders.PortPairs(

http=forwarders.PortPair(self.wpr_port_pairs.http.local_port,

self.GetRemotePort(