Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 739613004: Add v4l-utils to chromium third_party (Closed)

Created:
6 years, 1 month ago by henryhsu
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add v4l-utils to chromium third_party BUG=405861 TEST=SUCCESS according to: ./tools/checklicenses/checklicenses.py third_party/v4l-utils Committed: https://crrev.com/f2a9e2ba76379b096e914dd5e6fd6afb53323d76 Cr-Commit-Position: refs/heads/master@{#310557}

Patch Set 1 #

Patch Set 2 : remove unneeded files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1991 lines, -40 lines) Patch
A + third_party/v4l-utils/COPYING.libv4l View 17 chunks +46 lines, -40 lines 0 comments Download
A third_party/v4l-utils/ChangeLog View 1 chunk +1815 lines, -0 lines 0 comments Download
A third_party/v4l-utils/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/v4l-utils/README.chromium View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/v4l-utils/lib/include/libv4l2.h View 1 chunk +116 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (2 generated)
henryhsu
PTAL
6 years, 1 month ago (2014-11-19 03:49:22 UTC) #2
Pawel Osciak
On 2014/11/19 03:49:22, henryhsu wrote: > PTAL Given that we only include libv4l2.h in Chrome, ...
6 years, 1 month ago (2014-11-19 11:53:36 UTC) #3
henryhsu
done. PTAL
6 years, 1 month ago (2014-11-20 05:16:32 UTC) #4
cpu_(ooo_6.6-7.5)
I have 739613004 Add v4l-utils to chromium third_party 700383004 Add v4l-utils to chromium third_party please ...
6 years, 1 month ago (2014-11-20 22:43:24 UTC) #5
henryhsu
On 2014/11/20 22:43:24, cpu wrote: > I have > > > 739613004 > Add v4l-utils ...
6 years, 1 month ago (2014-11-21 06:08:07 UTC) #6
cpu_(ooo_6.6-7.5)
ok, folow http://www.chromium.org/developers/adding-3rd-party-libraries (looks like you are doing that) and ping me once you are ...
6 years ago (2014-11-21 20:41:43 UTC) #7
henryhsu
On 2014/11/21 20:41:43, cpu wrote: > ok, folow http://www.chromium.org/developers/adding-3rd-party-libraries (looks > like you are doing ...
6 years ago (2014-11-24 02:57:28 UTC) #8
henryhsu
PTAL.
6 years ago (2014-11-27 09:18:25 UTC) #9
cpu_(ooo_6.6-7.5)
sorry what has changed? still need approval from these two folks.
6 years ago (2014-12-01 16:43:09 UTC) #10
henryhsu
On 2014/12/01 16:43:09, cpu wrote: > sorry what has changed? still need approval from these ...
6 years ago (2014-12-01 17:08:13 UTC) #11
Jorge Lucangeli Obes
On 2014/12/01 17:08:13, henryhsu wrote: > On 2014/12/01 16:43:09, cpu wrote: > > sorry what ...
5 years, 11 months ago (2015-01-08 01:12:54 UTC) #12
henryhsu
Hi cpu, we got lgtm from open source third_party and security team. Please review it. ...
5 years, 11 months ago (2015-01-08 09:28:18 UTC) #13
cpu_(ooo_6.6-7.5)
lgtm
5 years, 11 months ago (2015-01-08 18:12:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739613004/20001
5 years, 11 months ago (2015-01-08 18:22:12 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-08 19:17:09 UTC) #17
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 19:21:05 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f2a9e2ba76379b096e914dd5e6fd6afb53323d76
Cr-Commit-Position: refs/heads/master@{#310557}

Powered by Google App Engine
This is Rietveld 408576698