Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 739303003: Cleanup pylint errors (Closed)

Created:
6 years, 1 month ago by Shezan Baig (Bloomberg)
Modified:
6 years, 1 month ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Mechanical changes to cleanup pylint presubmit checks BUG=gyp:469 R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=2006

Patch Set 1 #

Patch Set 2 : it's clean now #

Total comments: 7

Patch Set 3 : implemented changes from first round of review #

Patch Set 4 : Fix mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -140 lines) Patch
M PRESUBMIT.py View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M buildbot/buildbot_run.py View 1 chunk +3 lines, -3 lines 0 comments Download
M gyptest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M pylib/gyp/MSVSNew.py View 1 chunk +1 line, -1 line 0 comments Download
M pylib/gyp/MSVSSettings.py View 1 chunk +1 line, -1 line 0 comments Download
M pylib/gyp/MSVSVersion.py View 1 chunk +1 line, -1 line 0 comments Download
M pylib/gyp/__init__.py View 2 1 chunk +1 line, -1 line 0 comments Download
M pylib/gyp/common.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pylib/gyp/generator/cmake.py View 1 3 chunks +3 lines, -3 lines 0 comments Download
M pylib/gyp/generator/eclipse.py View 1 1 chunk +1 line, -1 line 0 comments Download
M pylib/gyp/generator/make.py View 1 1 chunk +1 line, -1 line 0 comments Download
M pylib/gyp/generator/msvs.py View 1 4 chunks +5 lines, -5 lines 0 comments Download
M pylib/gyp/generator/ninja.py View 1 4 chunks +5 lines, -4 lines 0 comments Download
M pylib/gyp/generator/xcode.py View 1 1 chunk +1 line, -1 line 0 comments Download
M pylib/gyp/input.py View 1 2 13 chunks +40 lines, -40 lines 0 comments Download
M pylib/gyp/mac_tool.py View 1 1 chunk +1 line, -1 line 0 comments Download
M pylib/gyp/xcode_emulation.py View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M pylib/gyp/xcodeproj_file.py View 1 18 chunks +40 lines, -41 lines 0 comments Download
M test/lib/TestWin.py View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mac/gyptest-rpath.py View 1 1 chunk +4 lines, -4 lines 0 comments Download
M test/msvs/buildevents/gyptest-ninja-warnings.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/msvs/filters/gyptest-filters-2010.py View 1 1 chunk +1 line, -1 line 0 comments Download
M test/multiple-targets/gyptest-all.py View 1 1 chunk +0 lines, -3 lines 0 comments Download
M test/multiple-targets/gyptest-default.py View 1 1 chunk +0 lines, -3 lines 0 comments Download
M test/sibling/gyptest-all.py View 1 1 chunk +0 lines, -3 lines 0 comments Download
M test/sibling/gyptest-relocate.py View 1 1 chunk +0 lines, -3 lines 0 comments Download
M test/subdirectory/gyptest-SYMROOT-all.py View 1 1 chunk +1 line, -1 line 0 comments Download
M test/subdirectory/gyptest-SYMROOT-default.py View 1 1 chunk +1 line, -1 line 0 comments Download
M test/win/gyptest-link-base-address.py View 1 1 chunk +1 line, -1 line 0 comments Download
M test/win/gyptest-link-profile.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/pretty_sln.py View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Shezan Baig (Bloomberg)
This CL affects a bunch of files, but it is mostly mechanical changes. I disabled ...
6 years, 1 month ago (2014-11-20 07:15:58 UTC) #2
scottmg
https://codereview.chromium.org/739303003/diff/20001/pylib/gyp/MSVSSettings.py File pylib/gyp/MSVSSettings.py (right): https://codereview.chromium.org/739303003/diff/20001/pylib/gyp/MSVSSettings.py#newcode5 pylib/gyp/MSVSSettings.py:5: r"""Code to validate and convert settings of the Microsoft ...
6 years, 1 month ago (2014-11-20 07:29:12 UTC) #3
Shezan Baig (Bloomberg)
https://codereview.chromium.org/739303003/diff/20001/pylib/gyp/MSVSSettings.py File pylib/gyp/MSVSSettings.py (right): https://codereview.chromium.org/739303003/diff/20001/pylib/gyp/MSVSSettings.py#newcode5 pylib/gyp/MSVSSettings.py:5: r"""Code to validate and convert settings of the Microsoft ...
6 years, 1 month ago (2014-11-20 07:48:22 UTC) #4
scottmg
Thanks for doing this. LGTM. https://codereview.chromium.org/739303003/diff/20001/pylib/gyp/MSVSSettings.py File pylib/gyp/MSVSSettings.py (right): https://codereview.chromium.org/739303003/diff/20001/pylib/gyp/MSVSSettings.py#newcode5 pylib/gyp/MSVSSettings.py:5: r"""Code to validate and ...
6 years, 1 month ago (2014-11-20 17:54:35 UTC) #5
Shezan Baig (Bloomberg)
The test/mac/gyptest-archs.py test seems flaky. Re-trying the same patchset seems ok now
6 years, 1 month ago (2014-11-21 00:11:53 UTC) #6
Shezan Baig (Bloomberg)
6 years, 1 month ago (2014-11-21 00:14:54 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 2006 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698