Cleanup pylint errors

pylib/gyp/xcode_emulation.py

 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 This module contains classes that help to emulate xcodebuild behavior on top of
 other build systems, such as make and ninja.
 """
 
 import copy
@@ skipping 97 matching lines @@
   For "iphoneos" and "iphonesimulator" SDKROOT, 64-bit architectures are part
   of $(ARCHS_STANDARD_INCLUDING_64_BIT) from Xcode 5.0. From Xcode 5.1, they
   are also part of $(ARCHS_STANDARD).
 
   All thoses rules are coded in the construction of the |XcodeArchsDefault|
   object to use depending on the version of Xcode detected. The object is
   for performance reason."""
   global XCODE_ARCHS_DEFAULT_CACHE
   if XCODE_ARCHS_DEFAULT_CACHE:
     return XCODE_ARCHS_DEFAULT_CACHE
+  # pylint: disable=unpacking-non-sequence
   xcode_version, _ = XcodeVersion()
   if xcode_version < '0500':
     XCODE_ARCHS_DEFAULT_CACHE = XcodeArchsDefault(
         '$(ARCHS_STANDARD)',
         XcodeArchsVariableMapping(['i386']),
         XcodeArchsVariableMapping(['i386']),
         XcodeArchsVariableMapping(['armv7']))
   elif xcode_version < '0510':
     XCODE_ARCHS_DEFAULT_CACHE = XcodeArchsDefault(
         '$(ARCHS_STANDARD_INCLUDING_64_BIT)',
@@ skipping 578 matching lines @@
     return install_name
 
   def _MapLinkerFlagFilename(self, ldflag, gyp_to_build_path):
     """Checks if ldflag contains a filename and if so remaps it from
     gyp-directory-relative to build-directory-relative."""
     # This list is expanded on demand.
     # They get matched as:
     #   -exported_symbols_list file
     #   -Wl,exported_symbols_list file
     #   -Wl,exported_symbols_list,file
-    LINKER_FILE = '(\S+)'
-    WORD = '\S+'
+    LINKER_FILE = r'r(\S+)'
+    WORD = r'r\S+'
     linker_flags = [
       ['-exported_symbols_list', LINKER_FILE],    # Needed for NaCl.
       ['-unexported_symbols_list', LINKER_FILE],
       ['-reexported_symbols_list', LINKER_FILE],
       ['-sectcreate', WORD, WORD, LINKER_FILE],   # Needed for remoting.
     ]
     for flag_pattern in linker_flags:
       regex = re.compile('(?:-Wl,)?' + '[ ,]'.join(flag_pattern))
       m = regex.match(ldflag)
       if m:
@@ skipping 291 matching lines @@
   def _XcodeIOSDeviceFamily(self, configname):
     family = self.xcode_settings[configname].get('TARGETED_DEVICE_FAMILY', '1')
     return [int(x) for x in family.split(',')]
 
   def GetExtraPlistItems(self, configname=None):
     """Returns a dictionary with extra items to insert into Info.plist."""
     if configname not in XcodeSettings._plist_cache:
       cache = {}
       cache['BuildMachineOSBuild'] = self._BuildMachineOSBuild()
 
+      # pylint: disable=unpacking-non-sequence

[scottmg, 2014/11/20 07:29:12]

there seems to be enough of these, maybe it would be better to globally disable
unpacking-non-sequence and tuple instead of annotating each.

[Shezan Baig (Bloomberg), 2014/11/20 07:48:22]

Makes sense, will do.

       xcode, xcode_build = XcodeVersion()
       cache['DTXcode'] = xcode
       cache['DTXcodeBuild'] = xcode_build
 
       sdk_root = self._SdkRoot(configname)
       if not sdk_root:
         sdk_root = self._DefaultSdkRoot()
       cache['DTSDKName'] = sdk_root
       if xcode >= '0430':
         cache['DTSDKBuild'] = self._GetSdkVersionInfoItem(
@@ skipping 18 matching lines @@
       items['UIDeviceFamily'] = self._XcodeIOSDeviceFamily(configname)
     return items
 
   def _DefaultSdkRoot(self):
     """Returns the default SDKROOT to use.
 
     Prior to version 5.0.0, if SDKROOT was not explicitly set in the Xcode
     project, then the environment variable was empty. Starting with this
     version, Xcode uses the name of the newest SDK installed.
     """
+    # pylint: disable=unpacking-non-sequence
     xcode_version, xcode_build = XcodeVersion()
     if xcode_version < '0500':
       return ''
     default_sdk_path = self._XcodeSdkPath('')
     default_sdk_root = XcodeSettings._sdk_root_cache.get(default_sdk_path)
     if default_sdk_root:
       return default_sdk_root
     try:
       all_sdks = GetStdout(['xcodebuild', '-showsdks'])
     except:
@@ skipping 129 matching lines @@
   if XCODE_VERSION_CACHE:
     return XCODE_VERSION_CACHE
   try:
     version_list = GetStdout(['xcodebuild', '-version']).splitlines()
     # In some circumstances xcodebuild exits 0 but doesn't return
     # the right results; for example, a user on 10.7 or 10.8 with
     # a bogus path set via xcode-select
     # In that case this may be a CLT-only install so fall back to
     # checking that version.
     if len(version_list) < 2:
-      raise GypError, "xcodebuild returned unexpected results"
+      raise GypError("xcodebuild returned unexpected results")
   except:
     version = CLTVersion()
     if version:
-      version = re.match('(\d\.\d\.?\d*)', version).groups()[0]
+      version = re.match(r'(\d\.\d\.?\d*)', version).groups()[0]
     else:
-      raise GypError, "No Xcode or CLT version detected!"
+      raise GypError("No Xcode or CLT version detected!")
     # The CLT has no build information, so we return an empty string.
     version_list = [version, '']
   version = version_list[0]
   build = version_list[-1]
   # Be careful to convert "4.2" to "0420":
   version = version.split()[-1].replace('.', '')
   version = (version + '0' * (3 - len(version))).zfill(4)
   if build:
     build = build.split()[-1]
   XCODE_VERSION_CACHE = (version, build)
@@ skipping 339 matching lines @@
       if toolset == 'target':
         iphoneos_config_dict['xcode_settings']['SDKROOT'] = 'iphoneos'
   return targets
 
 def CloneConfigurationForDeviceAndEmulator(target_dicts):
   """If |target_dicts| contains any iOS targets, automatically create -iphoneos
   targets for iOS device builds."""
   if _HasIOSTarget(target_dicts):
     return _AddIOSDeviceConfigurations(target_dicts)
   return target_dicts