Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: pylib/gyp/xcode_emulation.py

Issue 739303003: Cleanup pylint errors (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: Fix mac Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pylib/gyp/mac_tool.py ('k') | pylib/gyp/xcodeproj_file.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/xcode_emulation.py
diff --git a/pylib/gyp/xcode_emulation.py b/pylib/gyp/xcode_emulation.py
index 2f34bc6f169055e95c87f41881c376a622e345f7..92bf47e2cd5b876fe3c516fc3a7afdc82c5a518c 100644
--- a/pylib/gyp/xcode_emulation.py
+++ b/pylib/gyp/xcode_emulation.py
@@ -713,8 +713,8 @@ class XcodeSettings(object):
# -exported_symbols_list file
# -Wl,exported_symbols_list file
# -Wl,exported_symbols_list,file
- LINKER_FILE = '(\S+)'
- WORD = '\S+'
+ LINKER_FILE = r'(\S+)'
+ WORD = r'\S+'
linker_flags = [
['-exported_symbols_list', LINKER_FILE], # Needed for NaCl.
['-unexported_symbols_list', LINKER_FILE],
@@ -1213,13 +1213,13 @@ def XcodeVersion():
# In that case this may be a CLT-only install so fall back to
# checking that version.
if len(version_list) < 2:
- raise GypError, "xcodebuild returned unexpected results"
+ raise GypError("xcodebuild returned unexpected results")
except:
version = CLTVersion()
if version:
- version = re.match('(\d\.\d\.?\d*)', version).groups()[0]
+ version = re.match(r'(\d\.\d\.?\d*)', version).groups()[0]
else:
- raise GypError, "No Xcode or CLT version detected!"
+ raise GypError("No Xcode or CLT version detected!")
# The CLT has no build information, so we return an empty string.
version_list = [version, '']
version = version_list[0]
« no previous file with comments | « pylib/gyp/mac_tool.py ('k') | pylib/gyp/xcodeproj_file.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698