Dispatch key events to the currently focused window.

Dispatch key events to the currently focused window.

This fixes the browser demo. You can now enter text into the URL bar.

BUG=431047
R=sky@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/e28eebf4ea5075e92c0bbc40222ba57850fc613b

[Elliot Glaysher, 2014-11-18 22:31:25]

erg@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2014-11-18 22:36:38]

Is it possible to write test coverage?

https://codereview.chromium.org/737913002/diff/1/mojo/services/window_manager...
File mojo/services/window_manager/view_target.h (right):

https://codereview.chromium.org/737913002/diff/1/mojo/services/window_manager...
mojo/services/window_manager/view_target.h:52: void
set_focus_controller(FocusController* focus_controller) {
Document ownership.

https://codereview.chromium.org/737913002/diff/1/mojo/services/window_manager...
File mojo/services/window_manager/window_manager_app.cc (right):

https://codereview.chromium.org/737913002/diff/1/mojo/services/window_manager...
mojo/services/window_manager/window_manager_app.cc:284: if (focus_controller_)
Is it really possible to get here with no focuscontroller?

[Elliot Glaysher, 2014-11-18 23:52:30]

Made some changes to the focus rules so that I could add a unit test to focus
changes.

(Going forward and porting most of ui/wm/core/focus_controller_unittest.cc is
one of my next actions once the browser demo is unbroken.)

https://codereview.chromium.org/737913002/diff/1/mojo/services/window_manager...
File mojo/services/window_manager/view_target.h (right):

https://codereview.chromium.org/737913002/diff/1/mojo/services/window_manager...
mojo/services/window_manager/view_target.h:52: void
set_focus_controller(FocusController* focus_controller) {
On 2014/11/18 22:36:38, sky wrote:
> Document ownership.

Was unhappy with this. Instead of hanging it here, I added equivalents to the
aura client stuff, with the pointer being stored as a local property on the
View.

https://codereview.chromium.org/737913002/diff/1/mojo/services/window_manager...
File mojo/services/window_manager/window_manager_app.cc (right):

https://codereview.chromium.org/737913002/diff/1/mojo/services/window_manager...
mojo/services/window_manager/window_manager_app.cc:284: if (focus_controller_)
On 2014/11/18 22:36:38, sky wrote:
> Is it really possible to get here with no focuscontroller?

Not only is it possible, it is the default.

RegisterSubtree is called from OnEmbed() which is part of the delegate
interface. However, the thing that calls InitFocus() is also called from a
different OnEmbed() that observes the same View hierarchy.

In short, this was here for safety in case the observers are added in a
different order, but I'll drop it for now as I guess that's really unlikely.

[sky, 2014-11-19 03:40:02]

LGTM

[Elliot Glaysher, 2014-11-19 18:39:28]

Committed patchset #2 (id:20001) manually as
e28eebf4ea5075e92c0bbc40222ba57850fc613b (presubmit successful).