Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Side by Side Diff: mojo/services/window_manager/view_targeter.cc

Issue 737913002: Dispatch key events to the currently focused window. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Redo FocusController storage so that it is a local property on a view. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/services/window_manager/view_targeter.h" 5 #include "mojo/services/window_manager/view_targeter.h"
6 6
7 #include "mojo/services/window_manager/focus_controller.h"
7 #include "mojo/services/window_manager/view_target.h" 8 #include "mojo/services/window_manager/view_target.h"
8 9
9 namespace mojo { 10 namespace mojo {
10 11
11 ViewTargeter::ViewTargeter() {} 12 ViewTargeter::ViewTargeter() {}
12 13
13 ViewTargeter::~ViewTargeter() {} 14 ViewTargeter::~ViewTargeter() {}
14 15
15 ui::EventTarget* ViewTargeter::FindTargetForEvent(ui::EventTarget* root, 16 ui::EventTarget* ViewTargeter::FindTargetForEvent(ui::EventTarget* root,
16 ui::Event* event) { 17 ui::Event* event) {
17 // TODO(erg): We currently don't deal with key events very well here; we need 18 ViewTarget* view = static_cast<ViewTarget*>(root);
18 // to implement the logic in the aura version to fix key events here. 19 ViewTarget* target =
19 return EventTargeter::FindTargetForEvent(root, event); 20 event->IsKeyEvent()
21 ? FindTargetForKeyEvent(view, *static_cast<ui::KeyEvent*>(event))
22 : static_cast<ViewTarget*>(
23 EventTargeter::FindTargetForEvent(root, event));
24
25 // TODO(erg): The aura version of this method does a lot of work to handle
26 // dispatching to a target that isn't a child of |view|. For now, punt on
27 // this.
28 DCHECK_EQ(view->GetRoot(), target->GetRoot());
29
30 return target;
20 } 31 }
21 32
22 ui::EventTarget* ViewTargeter::FindTargetForLocatedEvent( 33 ui::EventTarget* ViewTargeter::FindTargetForLocatedEvent(
23 ui::EventTarget* root, 34 ui::EventTarget* root,
24 ui::LocatedEvent* event) { 35 ui::LocatedEvent* event) {
25 ViewTarget* view = static_cast<ViewTarget*>(root); 36 ViewTarget* view = static_cast<ViewTarget*>(root);
26 if (!view->HasParent()) { 37 if (!view->HasParent()) {
27 ViewTarget* target = FindTargetInRootView(view, *event); 38 ViewTarget* target = FindTargetInRootView(view, *event);
28 if (target) { 39 if (target) {
29 view->ConvertEventToTarget(target, event); 40 view->ConvertEventToTarget(target, event);
(...skipping 21 matching lines...) Expand all
51 ui::EventTarget* target, 62 ui::EventTarget* target,
52 const ui::LocatedEvent& event) const { 63 const ui::LocatedEvent& event) const {
53 ViewTarget* view = static_cast<ViewTarget*>(target); 64 ViewTarget* view = static_cast<ViewTarget*>(target);
54 gfx::Point point = event.location(); 65 gfx::Point point = event.location();
55 const ViewTarget* parent = view->GetParent(); 66 const ViewTarget* parent = view->GetParent();
56 if (parent) 67 if (parent)
57 ViewTarget::ConvertPointToTarget(parent, view, &point); 68 ViewTarget::ConvertPointToTarget(parent, view, &point);
58 return gfx::Rect(view->GetBounds().size()).Contains(point); 69 return gfx::Rect(view->GetBounds().size()).Contains(point);
59 } 70 }
60 71
72 ViewTarget* ViewTargeter::FindTargetForKeyEvent(ViewTarget* view_target,
73 const ui::KeyEvent& key) {
74 FocusController* focus_controller = GetFocusController(view_target->view());
75 View* focused_view = focus_controller->GetFocusedView();
76 if (focused_view)
77 return ViewTarget::TargetFromView(focused_view);
78
79 return view_target;
80 }
81
61 ViewTarget* ViewTargeter::FindTargetInRootView(ViewTarget* root_view, 82 ViewTarget* ViewTargeter::FindTargetInRootView(ViewTarget* root_view,
62 const ui::LocatedEvent& event) { 83 const ui::LocatedEvent& event) {
63 // TODO(erg): This here is important because it resolves 84 // TODO(erg): This here is important because it resolves
64 // mouse_pressed_handler() in the aura version. This is what makes sure 85 // mouse_pressed_handler() in the aura version. This is what makes sure
65 // that a view gets both the mouse down and up. 86 // that a view gets both the mouse down and up.
66 87
67 // TODO(erg): We redirect to a currently active capture window here. Add this 88 // TODO(erg): We redirect to a currently active capture window here. Add this
68 // when we have capture working. 89 // when we have capture working.
69 90
70 // TODO(erg): There's a whole bunch of junk about handling touch events 91 // TODO(erg): There's a whole bunch of junk about handling touch events
71 // here. Handle later. 92 // here. Handle later.
72 93
73 return nullptr; 94 return nullptr;
74 } 95 }
75 96
76 } // namespace mojo 97 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/services/window_manager/view_targeter.h ('k') | mojo/services/window_manager/view_targeter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698