mojo/services/window_manager/basic_focus_rules.h - Issue 737913002: Dispatch key events to the currently focused window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/window_manager/basic_focus_rules.h

Issue 737913002: Dispatch key events to the currently focused window. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Redo FocusController storage so that it is a local property on a view. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/window_manager/basic_focus_rules.h

diff --git a/mojo/services/window_manager/basic_focus_rules.h b/mojo/services/window_manager/basic_focus_rules.h

index fd72e850d44dcb6fb51ed95a644cce39bdda8ceb..e5db4de4664d52f4f381a73d74b31f4c2bee4f8f 100644

--- a/mojo/services/window_manager/basic_focus_rules.h

+++ b/mojo/services/window_manager/basic_focus_rules.h

@@ -9,7 +9,6 @@

namespace mojo {

-class WindowManagerApp;

class View;

// The focusing rules used inside a window manager.

@@ -22,8 +21,7 @@ class View;

// is very incomplete. crbug.com/431047

class BasicFocusRules : public FocusRules {

public:

- BasicFocusRules(mojo::WindowManagerApp* window_manager_app,

- mojo::View* window_container);

+ BasicFocusRules(mojo::View* window_container);

~BasicFocusRules() override;

protected:

@@ -38,7 +36,6 @@ class BasicFocusRules : public FocusRules {

private:

mojo::View* window_container_;

- mojo::WindowManagerApp* window_manager_app_;

DISALLOW_COPY_AND_ASSIGN(BasicFocusRules);

};