Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 737663003: Remove MessageInTransit::kTypeMessagePipe; rename kTypeMessagePipeEndpoint to kTypeEndpoint; etc. (Closed)

Created:
6 years ago by viettrungluu
Modified:
6 years ago
Reviewers:
yzshen1
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove MessageInTransit::kTypeMessagePipe; rename kTypeMessagePipeEndpoint to kTypeEndpoint; etc. R=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5b4cb28a9c971c9404870fc3fdfaa99e9ccc336a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -46 lines) Patch
M mojo/edk/system/channel.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/channel.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M mojo/edk/system/message_in_transit.h View 1 chunk +6 lines, -10 lines 0 comments Download
M mojo/edk/system/message_in_transit.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M mojo/edk/system/message_pipe.h View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/edk/system/message_pipe.cc View 3 chunks +3 lines, -16 lines 0 comments Download
M mojo/edk/system/raw_channel_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years ago (2014-12-01 22:43:34 UTC) #1
yzshen1
lgtm
6 years ago (2014-12-01 22:59:44 UTC) #2
viettrungluu
6 years ago (2014-12-01 23:07:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5b4cb28a9c971c9404870fc3fdfaa99e9ccc336a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698