Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: mojo/edk/system/channel.cc

Issue 737663003: Remove MessageInTransit::kTypeMessagePipe; rename kTypeMessagePipeEndpoint to kTypeEndpoint; etc. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/channel.h ('k') | mojo/edk/system/message_in_transit.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/channel.cc
diff --git a/mojo/edk/system/channel.cc b/mojo/edk/system/channel.cc
index d678d0e83cdb7bdbf0787129e35dafcdc3890a03..92eb8b015076b82e0ea2b4bf34d5dca55468a575 100644
--- a/mojo/edk/system/channel.cc
+++ b/mojo/edk/system/channel.cc
@@ -236,9 +236,8 @@ void Channel::OnReadMessage(
DCHECK(creation_thread_checker_.CalledOnValidThread());
switch (message_view.type()) {
- case MessageInTransit::kTypeMessagePipeEndpoint:
- case MessageInTransit::kTypeMessagePipe:
- OnReadMessageForDownstream(message_view, platform_handles.Pass());
+ case MessageInTransit::kTypeEndpoint:
+ OnReadMessageForEndpoint(message_view, platform_handles.Pass());
break;
case MessageInTransit::kTypeChannel:
OnReadMessageForChannel(message_view, platform_handles.Pass());
@@ -282,12 +281,11 @@ void Channel::OnError(Error error) {
Shutdown();
}
-void Channel::OnReadMessageForDownstream(
+void Channel::OnReadMessageForEndpoint(
const MessageInTransit::View& message_view,
embedder::ScopedPlatformHandleVectorPtr platform_handles) {
DCHECK(creation_thread_checker_.CalledOnValidThread());
- DCHECK(message_view.type() == MessageInTransit::kTypeMessagePipeEndpoint ||
- message_view.type() == MessageInTransit::kTypeMessagePipe);
+ DCHECK(message_view.type() == MessageInTransit::kTypeEndpoint);
ChannelEndpointId local_id = message_view.destination_id();
if (!local_id.is_valid()) {
« no previous file with comments | « mojo/edk/system/channel.h ('k') | mojo/edk/system/message_in_transit.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698