Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 737353003: Fix WeakPtrFactory member ordering in content (Closed)

Created:
6 years, 1 month ago by MRV
Modified:
6 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, dmichael (off chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix WeakPtrFactory member ordering in content Changing in the intialization order of WeakPtrFactory such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/aae039a4d509bd6b3d96b42829cbedc10804bbdb Cr-Commit-Position: refs/heads/master@{#305234}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Incorporated comments #

Patch Set 3 : Resolving error #

Patch Set 4 : Resolving weakptr errors #

Patch Set 5 : Resolved getptr issue #

Patch Set 6 : Resolved typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 3 chunks +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 5 2 chunks +4 lines, -7 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/scheduler/task_queue_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/scheduler/task_queue_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
MRV
PTAL
6 years, 1 month ago (2014-11-20 13:31:28 UTC) #2
Avi (use Gerrit)
https://codereview.chromium.org/737353003/diff/1/content/browser/renderer_host/render_widget_host_view_aura.h File content/browser/renderer_host/render_widget_host_view_aura.h (right): https://codereview.chromium.org/737353003/diff/1/content/browser/renderer_host/render_widget_host_view_aura.h#newcode90 content/browser/renderer_host/render_widget_host_view_aura.h:90: public base::SupportsWeakPtr<RenderWidgetHostViewAura> { It's silly for RenderWidgetHostViewAura to be ...
6 years, 1 month ago (2014-11-20 15:54:46 UTC) #3
MRV
Thanks mr. avi for reviewing the patch. I have incorporated the changes now. PTAL https://codereview.chromium.org/737353003/diff/1/content/browser/renderer_host/render_widget_host_view_aura.h ...
6 years, 1 month ago (2014-11-21 15:08:30 UTC) #4
Avi (use Gerrit)
lgtm Thanks!
6 years, 1 month ago (2014-11-21 15:57:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/737353003/100001
6 years, 1 month ago (2014-11-21 16:39:43 UTC) #7
MRV
On 2014/11/21 15:57:42, Avi wrote: > lgtm > > Thanks! Thanks mr.avi for reviewing patch.
6 years, 1 month ago (2014-11-21 16:40:23 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
6 years, 1 month ago (2014-11-21 17:39:58 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 17:40:48 UTC) #10
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/aae039a4d509bd6b3d96b42829cbedc10804bbdb
Cr-Commit-Position: refs/heads/master@{#305234}

Powered by Google App Engine
This is Rietveld 408576698