Fix WeakPtrFactory member ordering in content

Fix WeakPtrFactory member ordering in content

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818
Committed: https://crrev.com/aae039a4d509bd6b3d96b42829cbedc10804bbdb
Cr-Commit-Position: refs/heads/master@{#305234}

[MRV, 2014-11-20 13:31:28]

mohan.reddy@samsung.com changed reviewers:
+ avi@chromium.org

[MRV, 2014-11-20 13:31:28]

PTAL

[Avi (use Gerrit), 2014-11-20 15:54:46]

https://codereview.chromium.org/737353003/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_aura.h (right):

https://codereview.chromium.org/737353003/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_aura.h:90: public
base::SupportsWeakPtr<RenderWidgetHostViewAura> {
It's silly for RenderWidgetHostViewAura to be both a SupportsWeakPtr and have a
WeakPtrFactory. Please switch away from SupportsWeakPtr.

https://codereview.chromium.org/737353003/diff/1/content/browser/web_contents...
File content/browser/web_contents/web_contents_impl.h (right):

https://codereview.chromium.org/737353003/diff/1/content/browser/web_contents...
content/browser/web_contents/web_contents_impl.h:1233: bool
virtual_keyboard_requested_;
Ok, this wasn't you who screwed up, but someone put this in after the weak ptr
factory and forgot to add it to the initializers. Can you initialize it?

[MRV, 2014-11-21 15:08:30]

Thanks mr. avi for reviewing the patch.
I have incorporated the changes now.
PTAL

https://codereview.chromium.org/737353003/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_aura.h (right):

https://codereview.chromium.org/737353003/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_aura.h:90: public
base::SupportsWeakPtr<RenderWidgetHostViewAura> {
On 2014/11/20 15:54:45, Avi wrote:
> It's silly for RenderWidgetHostViewAura to be both a SupportsWeakPtr and have
a
> WeakPtrFactory. Please switch away from SupportsWeakPtr.

Done.

https://codereview.chromium.org/737353003/diff/1/content/browser/web_contents...
File content/browser/web_contents/web_contents_impl.h (right):

https://codereview.chromium.org/737353003/diff/1/content/browser/web_contents...
content/browser/web_contents/web_contents_impl.h:1233: bool
virtual_keyboard_requested_;
On 2014/11/20 15:54:45, Avi wrote:
> Ok, this wasn't you who screwed up, but someone put this in after the weak ptr
> factory and forgot to add it to the initializers. Can you initialize it?

Done.

[Avi (use Gerrit), 2014-11-21 15:57:42]

lgtm

Thanks!

[MRV, 2014-11-21 16:39:34]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-11-21 16:39:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/737353003/100001

[MRV, 2014-11-21 16:40:23]

On 2014/11/21 15:57:42, Avi wrote:
> lgtm
> 
> Thanks!

Thanks mr.avi for reviewing patch.

[commit-bot: I haz the power, 2014-11-21 17:39:58]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-11-21 17:40:48]

Patchset 6 (id:??) landed as
https://crrev.com/aae039a4d509bd6b3d96b42829cbedc10804bbdb
Cr-Commit-Position: refs/heads/master@{#305234}