Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 737353003: Fix WeakPtrFactory member ordering in content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolved typo Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index 9d6b2e2e662ce5287583e907cba01822f41e097e..ff6ee6a01b05941ef17270ce9b1ed888e172e610 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -1280,9 +1280,8 @@ void RenderWidgetHostViewAura::ShowDisambiguationPopup(
disambiguation_target_rect_,
zoomed_size,
base::Bind(&RenderWidgetHostViewAura::DisambiguationPopupRendered,
- base::internal::SupportsWeakPtrBase::StaticAsWeakPtr
- <RenderWidgetHostViewAura>(this)),
- kN32_SkColorType);
+ weak_ptr_factory_.GetWeakPtr()),
+ kN32_SkColorType);
}
void RenderWidgetHostViewAura::DisambiguationPopupRendered(
@@ -1308,11 +1307,9 @@ void RenderWidgetHostViewAura::DisambiguationPopupRendered(
disambiguation_target_rect_,
result,
base::Bind(&RenderWidgetHostViewAura::ProcessDisambiguationGesture,
- base::internal::SupportsWeakPtrBase::StaticAsWeakPtr
- <RenderWidgetHostViewAura>(this)),
+ weak_ptr_factory_.GetWeakPtr()),
base::Bind(&RenderWidgetHostViewAura::ProcessDisambiguationMouse,
- base::internal::SupportsWeakPtrBase::StaticAsWeakPtr
- <RenderWidgetHostViewAura>(this)));
+ weak_ptr_factory_.GetWeakPtr()));
}
}
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.h ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698